From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932992AbbHDK4X (ORCPT <rfc822;w@1wt.eu>);
	Tue, 4 Aug 2015 06:56:23 -0400
Received: from mailout2.samsung.com ([203.254.224.25]:51688 "EHLO
	mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932332AbbHDK4V (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 4 Aug 2015 06:56:21 -0400
X-AuditID: cbfee691-f79ca6d00000456a-03-55c09a53ac31
Message-id: <55C09A52.1090201@samsung.com>
Date: Tue, 04 Aug 2015 19:56:18 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106
 Thunderbird/17.0.2
MIME-version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>, Roger Quadros <rogerq@ti.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] extcon: signedness bugs break error handling
References: <20150804074723.GC10867@mwanda>
In-reply-to: <20150804074723.GC10867@mwanda>
Content-type: text/plain; charset=ISO-8859-1
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsWyRsSkQDd41oFQg92zWSxe/5vOYrH1lrTF
	5V1z2CxuN65gs+h5pOXA6vHx6S0Wj74tqxg9jt/YzuTxeZNcAEsUl01Kak5mWWqRvl0CV0bb
	+pesBftYKg48/8XawHifuYuRk0NCwESi59g7KFtM4sK99WxdjFwcQgIrGCVeHZ7ADlN0veM7
	C4gtJDCLUeL1i3qIogeMErumPAXr5hXQkpj6/QlYA4uAqsSk+yCTODnYgOL7X9wAs0UFwiRW
	Tr/CAlEvKPFj8j0wW0RAR+Jy5w+wXmaBbkaJY4ssQWxhAUeJa9d6mCAWa0v8uTATqIaDgxOo
	/skyVohyHYn9rdPYIGx5ic1r3jKD3CYhsIld4l/nAjaIewQkvk0+xALSKyEgK7HpANTDkhIH
	V9xgmcAoNgvJRbOQjJ2FZOwCRuZVjKKpBckFxUnpRaZ6xYm5xaV56XrJ+bmbGIExdfrfs4k7
	GO8fsD7EKMDBqMTDK/Byf6gQa2JZcWXuIUZToCsmMkuJJucDIzevJN7Q2MzIwtTE1NjI3NJM
	SZxXR/pnsJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQbG5X+1zNe8bTI9bavFpN71/mvk3kO/
	GEqmOr1UmTRd3pMpmKt6W0At06K5p04d8zfb1bloR3P0p1ZNBpY9nAu/T2gROykgW+h2fO/P
	kvo3M9MnM5+0uREwY/JxN53sq92O3eaJOZ45nOne27c+lNvc8uzb32fi995oeHPseWDRsO3j
	tBRxiVd5SizFGYmGWsxFxYkAprBuJqQCAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsVy+t9jQd2gWQdCDb7ttrF4/W86i8XWW9IW
	l3fNYbO43biCzaLnkZYDq8fHp7dYPPq2rGL0OH5jO5PH501yASxRDYw2GamJKalFCql5yfkp
	mXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBrlRTKEnNKgUIBicXFSvp2mCaE
	hrjpWsA0Ruj6hgTB9RgZoIGENYwZbetfshbsY6k48PwXawPjfeYuRk4OCQETiesd31kgbDGJ
	C/fWs4HYQgKzGCVev6jvYuQCsh8wSuya8hSsgVdAS2Lq9yfsIDaLgKrEpPsQDWxA8f0vboDZ
	ogJhEiunX2GBqBeU+DH5HpgtIqAjcbnzB1gvs0A3o8SxRZYgtrCAo8S1az1MEIu1Jf5cmAlU
	w8HBCVT/ZBkrRLmOxP7WaWwQtrzE5jVvmScwAh2JsGEWkrJZSMoWMDKvYpRILUguKE5KzzXM
	Sy3XK07MLS7NS9dLzs/dxAiO22dSOxgP7nI/xCjAwajEwyvwcn+oEGtiWXFl7iFGCQ5mJRFe
	g6oDoUK8KYmVValF+fFFpTmpxYcYTYFhMJFZSjQ5H5hS8kriDY1NzIwsjcwNLYyMzZXEeWU3
	bA4VEkhPLEnNTk0tSC2C6WPi4JRqYDx7l9HT5OQPl32rr9y8cKZ02aPrX3wSjJmzV88xbz5s
	e0qsq2i227yC9O9v7hxerfJ0bfFth6WeDq9OTDJWupO+eKGjelC9ld7Si/lbDiW/mii3ryT9
	uGhGCZOi7gT7yJlPjI6ffl2653fXrZO2Ptq7K7/a8j9/ozlJbtYJhY8brO0WZOQ7Bc5XYinO
	SDTUYi4qTgQAcptD5vECAAA=
DLP-Filter: Pass
X-MTR: 20000000000000000@CPGS
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/04/2015 04:47 PM, Dan Carpenter wrote:
> Unsigned is never less than zero so this error handling won't work.
> 
> Fixes: be052cc87745 ('extcon: Fix hang and extcon_get/set_cable_state().')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 8301a72..da2fb6c 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)
>  

Applied it. 

Thanks,
Chanwoo Choi