From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756092AbbHDLLF (ORCPT ); Tue, 4 Aug 2015 07:11:05 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:33206 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756013AbbHDLLE (ORCPT ); Tue, 4 Aug 2015 07:11:04 -0400 Subject: Re: [PATCH net] virtio-net: drop NETIF_F_FRAGLIST To: Jason Wang , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1438682145-25986-1-git-send-email-jasowang@redhat.com> Cc: mst@redhat.com From: Sergei Shtylyov Message-ID: <55C09DC4.4070108@cogentembedded.com> Date: Tue, 4 Aug 2015 14:11:00 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438682145-25986-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 8/4/2015 12:55 PM, Jason Wang wrote: > virtio declares support for NETIF_F_FRAGLIST, but assumes > that there are at most MAX_SKB_FRAGS + 2 fragments which isn't > always true with a fraglist. > A longer fraglist in the skb will make the call to skb_to_sgvec overflow > the sg array, leading to memory corruption. > Drop NETIF_F_FRAGLIST so we only get what we can handle. > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang > --- > The patch is needed for stable. > --- > drivers/net/virtio_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 7fbca37..2347a73 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1756,9 +1756,9 @@ static int virtnet_probe(struct virtio_device *vdev) > /* Do we support "hardware" checksums? */ > if (virtio_has_feature(vdev, VIRTIO_NET_F_CSUM)) { > /* This opens up the world of extra features. */ > - dev->hw_features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST; > + dev->hw_features |= NETIF_F_HW_CSUM|NETIF_F_SG; > if (csum) > - dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST; > + dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG; I'd have added spaces around | to match the style seen below. > if (virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) { > dev->hw_features |= NETIF_F_TSO | NETIF_F_UFO MBR, Sergei