From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754850AbbHDO1S (ORCPT ); Tue, 4 Aug 2015 10:27:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:35543 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754095AbbHDO1Q (ORCPT ); Tue, 4 Aug 2015 10:27:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,609,1432623600"; d="scan'208";a="761695935" Message-ID: <55C0CBC3.2000602@intel.com> Date: Tue, 04 Aug 2015 07:27:15 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Xishi Qiu CC: Andrew Morton , Mel Gorman , Vlastimil Babka , Johannes Weiner , Michal Hocko , iamjoonsoo.kim@lge.com, alexander.h.duyck@redhat.com, sasha.levin@oracle.com, Linux MM , LKML Subject: Re: [PATCH] mm: add the block to the tail of the list in expand() References: <55BB4027.7080200@huawei.com> <55BC0392.2070205@intel.com> <55BECC85.7050206@huawei.com> <55BEE99E.8090901@intel.com> <55C011A6.1090003@huawei.com> In-Reply-To: <55C011A6.1090003@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2015 06:13 PM, Xishi Qiu wrote: > How did you do the experiment? I just stuck in some counters in expand() that looked to see whether the list was empty or not when the page is added and then printed them out occasionally. It will be interesting to see the results both on a freshly-booted system and one that's reached relatively steady-state and is moving around a minimal number of pageblocks between the different types. In any case, the end result here needs to be some indication that the patch either helps ease fragmentation or helps performance.