From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbbHDR66 (ORCPT ); Tue, 4 Aug 2015 13:58:58 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59604 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbbHDR64 (ORCPT ); Tue, 4 Aug 2015 13:58:56 -0400 Message-ID: <55C0FD5E.7000705@codeaurora.org> Date: Tue, 04 Aug 2015 10:58:54 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Robert Jarzmik CC: Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Ezequiel Garcia Subject: Re: [PATCH] clk: pxa: pxa3xx: fix CKEN register access References: <1438631907-27993-1-git-send-email-robert.jarzmik@free.fr> <55C00A6B.2030508@codeaurora.org> <87h9ofmv2n.fsf@belgarion.home> In-Reply-To: <87h9ofmv2n.fsf@belgarion.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2015 11:22 PM, Robert Jarzmik wrote: > Stephen Boyd writes: > >> On 08/03/2015 12:58 PM, Robert Jarzmik wrote: >>> Clocks 0 to 31 are on CKENA, and not CKENB. The clock register names >>> were inadequately inverted. As a consequence, all clock operations were >>> happening on CKENB, because almost all but 2 clocks are on CKENA. >>> >>> As the clocks were activated by the bootloader in the former tests, it >>> escaped the testing that the wrong clock gate was manipulated. The error >>> was revealed by changing the pxa3xx-and driver to a module, where tupon >>> unloading the wrong clock was disabled in CKENB. >>> >>> Signed-off-by: Robert Jarzmik >>> --- >> Did you want a fixes tag to send this back to stable? > Ah yes, good point, v2 on its way. > > Stephen and Mike, do you think this can still get in -rc6 ? > It's not a new regression for v4.2 so we'll leave it to v4.3. I'll apply it to clk-next. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project