From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbbHEIJW (ORCPT ); Wed, 5 Aug 2015 04:09:22 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:35102 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbbHEIJL (ORCPT ); Wed, 5 Aug 2015 04:09:11 -0400 Message-ID: <55C1C486.6050202@ti.com> Date: Wed, 5 Aug 2015 11:08:38 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I , , , , , , , CC: , , , Subject: Re: [PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node References: <1438702233-8027-1-git-send-email-kishon@ti.com> <1438702233-8027-11-git-send-email-kishon@ti.com> <55C1C325.5040703@ti.com> In-Reply-To: <55C1C325.5040703@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/15 11:02, Roger Quadros wrote: > Kishon, > > On 04/08/15 18:30, Kishon Vijay Abraham I wrote: >> Add "syscon-otghs" property and remove the deprecated "ctrl-module" >> property from MUSB devicetree node. >> >> Since "omap_control_usbotg" devicetree node is no longer used, remove >> it. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/omap4.dtsi | 8 +------- >> 1 file changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi >> index b27634d..2fb49a5 100644 >> --- a/arch/arm/boot/dts/omap4.dtsi >> +++ b/arch/arm/boot/dts/omap4.dtsi >> @@ -854,12 +854,6 @@ >> }; >> }; >> >> - omap_control_usbotg: control-phy@4a00233c { >> - compatible = "ti,control-phy-otghs"; >> - reg = <0x4a00233c 0x4>; >> - reg-names = "otghs_control"; >> - }; >> - >> usb_otg_hs: usb_otg_hs@4a0ab000 { >> compatible = "ti,omap4-musb"; >> reg = <0x4a0ab000 0x7ff>; >> @@ -872,7 +866,7 @@ >> multipoint = <1>; >> num-eps = <16>; >> ram-bits = <12>; >> - ctrl-module = <&omap_control_usbotg>; >> + syscon-otghs = <&scm_conf 0x33c>; > > All other properties were of the format "syscon-phy-foo". > Why use a different format here? > Ah, looks like we don't have a dedicated phy driver for this? We will need to add a PHY driver I guess then and handle this register in that driver rather than in the musb driver. cheers, -roger > > >> }; >> >> aes: aes@4b501000 { >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >