From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
David Daney <ddaney.cavm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Len Brown <lenb@kernel.org>, Robert Richter <rrichter@cavium.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call.
Date: Wed, 05 Aug 2015 15:43:18 +0200 [thread overview]
Message-ID: <55C212F6.40504@linaro.org> (raw)
In-Reply-To: <5621301.c1YGTkGNQk@vostro.rjw.lan>
On 05.08.2015 15:48, Rafael J. Wysocki wrote:
> On Tuesday, August 04, 2015 04:01:59 PM David Daney wrote:
>> From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
>>
>> Fixes the following build error when building drivers as modules:
>>
>> ERROR: "acpi_dev_prop_read_single" [drivers/net/phy/mdio-octeon.ko] undefined!
>> ERROR: "acpi_dev_prop_read_single" [drivers/net/ethernet/cavium/thunder/thunder_bgx.ko] undefined!
>
> Can you please tell me why the drivers in question use that function
> directly, although they aren't supposed to?
>
> Clearly, their authors had not tried to build them as modules or they
> would have noticed the problem at the development stage already.
>
> What would be wrong with using the generic device properties API instead?
>
Yes, you are right. We should use:
int device_property_read_u64_array(struct device *dev, const char
*propname, u64 *val, size_t nval);
Regards,
Tomasz
next prev parent reply other threads:[~2015-08-05 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 23:01 [PATCH] acpi, property: Export acpi_dev_prop_read_single call David Daney
2015-08-05 13:48 ` Rafael J. Wysocki
2015-08-05 13:43 ` Tomasz Nowicki [this message]
2015-08-05 17:26 ` David Daney
2015-08-05 20:14 ` David Daney
2015-08-05 23:23 ` Rafael J. Wysocki
2015-08-05 23:17 ` David Daney
2015-08-05 23:55 ` Rafael J. Wysocki
2015-08-05 23:49 ` David Daney
2015-08-05 23:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C212F6.40504@linaro.org \
--to=tomasz.nowicki@linaro.org \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rrichter@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).