From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbbHEOv5 (ORCPT ); Wed, 5 Aug 2015 10:51:57 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:52537 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbbHEOvz (ORCPT ); Wed, 5 Aug 2015 10:51:55 -0400 Message-ID: <55C22305.2030403@roeck-us.net> Date: Wed, 05 Aug 2015 07:51:49 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Punit Agrawal , linux-pm@vger.kernel.org CC: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, liviu.dudau@arm.com, Eduardo Valentin , Zhang Rui Subject: Re: [PATCH v3] thermal: Fix thermal_zone_of_sensor_register to match documentation References: <9hha8u7mi7a.fsf@e105922-lin.cambridge.arm.com> <1438768668-15225-1-git-send-email-punit.agrawal@arm.com> In-Reply-To: <1438768668-15225-1-git-send-email-punit.agrawal@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2015 02:57 AM, Punit Agrawal wrote: > thermal_zone_of_sensor_register is documented as returning a pointer > to either a valid thermal_zone_device on success, or a corresponding > ERR_PTR() value. > > In contrast, the function returns NULL when THERMAL_OF is configured > off. Fix this. > > Signed-off-by: Punit Agrawal > Cc: Guenter Roeck > Cc: Eduardo Valentin > Cc: Zhang Rui Acked-by: Guenter Roeck > --- > Hi Guenter, > > It was pointed out that ENOSYS is frowned upon for anything other than > indicating lack of support for a syscall. The rest of the functions in > the file use ENODEV. Updating thermal_zone_of_sensor_register to do > the same. > > Could you please re-ack if you're ok with this change? > > Thanks, > Punit > > include/linux/thermal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index 037e9df..f344e51 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -364,7 +364,7 @@ static inline struct thermal_zone_device * > thermal_zone_of_sensor_register(struct device *dev, int id, void *data, > const struct thermal_zone_of_device_ops *ops) > { > - return NULL; > + return ERR_PTR(-ENODEV); > } > > static inline >