From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755397AbbHFKve (ORCPT ); Thu, 6 Aug 2015 06:51:34 -0400 Received: from smtp6-v.fe.bosch.de ([139.15.237.11]:16021 "EHLO smtp6-v.fe.bosch.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378AbbHFKvc (ORCPT ); Thu, 6 Aug 2015 06:51:32 -0400 Subject: Re: [PATCH 1/2] Input: atmel_mxt_ts - Implement support for T100 touch object To: Javier Martinez Canillas , Dmitry Torokhov References: <1426600846-13346-1-git-send-email-javier.martinez@collabora.co.uk> <1426600846-13346-2-git-send-email-javier.martinez@collabora.co.uk> CC: Henrik Rydberg , Nick Dyer , Sjoerd Simons , Doug Anderson , Olof Johansson , Yufeng Shen , Benson Leung , Chung-yih Wang , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Dirk Behme Organization: Robert Bosch Car Multimedia GmbH Message-ID: <55C33C30.9080807@de.bosch.com> Date: Thu, 6 Aug 2015 12:51:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1426600846-13346-2-git-send-email-javier.martinez@collabora.co.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.34.211.40] X-TM-AS-MML: disable X-TM-AS-Product-Ver: IMSS-7.1.0.1679-7.5.0.1018-21728.006 X-TMASE-MatchedRID: QfHZjzml1E8OwH4pD14DsPHkpkyUphL9SBu7cluRi1xcKZwALwMGs4AX rQfh62bu6oELKh7X24ULZSfC3OHnLCvIUds2cEsbnVTWWiNp+v/dIoYX0NG1+DpPoMRMO7Sy5n5 vVjME/yFOFu8ssjxG86HTKqpRnt9PESUQs9x1RCdVXhlmZsTdjEb8lR3sG9JCMLk1AGUYTYvwtZ Wtkkk1NKMDc1Bj4tKdbDMg9RQFXyoQnhzntItSfLrbxxduc6FP9pLnYtQ99xKYN5o4ZKM2rqPFj JEFr+olfeZdJ1Xsorj7goPHX5O3RAtuKBGekqUpI/NGWt0UYPB14HG1V8YKCuUwGybaP/2/XizN UktOGKIXegGeJ8oTp1HMRfvrI0H3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.03.2015 15:00, Javier Martinez Canillas wrote: > From: Nick Dyer > > Add support for the new T100 object which replaces the previous > T9 multitouch touchscreen object in recent maXTouch devices. > T100 provides improved reporting with selectable auxiliary > information, and a type field for hover/stylus/glove reporting. > > The hovering finger support was based on Chung-Yih's work in > the ChromiumOS downstream kernel: > > https://chromium-review.googlesource.com/#/c/219280/ > > Signed-off-by: Nick Dyer > Acked-by: Yufeng Shen > [javier: Factor out T9 and T100 init functions and rework hover support] > Signed-off-by: Javier Martinez Canillas > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 323 +++++++++++++++++++++++++++++-- > 1 file changed, 302 insertions(+), 21 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 95ee92a91bd2..749371761669 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c ... > @@ -1612,9 +1856,8 @@ static int mxt_initialize_t9_input_device(struct mxt_data *data) > input_dev->open = mxt_input_open; > input_dev->close = mxt_input_close; > > - __set_bit(EV_ABS, input_dev->evbit); > - __set_bit(EV_KEY, input_dev->evbit); > - __set_bit(BTN_TOUCH, input_dev->keybit); > + set_bit(EV_ABS, input_dev->evbit); > + input_set_capability(input_dev, EV_KEY, BTN_TOUCH); Having this patch in mainline as commit b23157dc74272ac8ebffd1a566e3e822dbc3e65f [1] breaks our Atmel touch. It seems that above + set_bit(EV_ABS, input_dev->evbit); is missing in the version which went into mainline? Re-adding it makes it work for us, again. Opinions? Best regards Dirk [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/input/touchscreen/atmel_mxt_ts.c?id=b23157dc74272ac8ebffd1a566e3e822dbc3e65f