From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Dirk Behme <dirk.behme@de.bosch.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Nick Dyer <nick.dyer@itdev.co.uk>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Yufeng Shen <miletus@chromium.org>,
Benson Leung <bleung@chromium.org>,
Chung-yih Wang <cywang@chromium.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Input: atmel_mxt_ts - Implement support for T100 touch object
Date: Thu, 6 Aug 2015 13:19:12 +0200 [thread overview]
Message-ID: <55C342B0.1060301@osg.samsung.com> (raw)
In-Reply-To: <1438859498.3362.12.camel@collabora.co.uk>
Hello,
On 08/06/2015 01:11 PM, Sjoerd Simons wrote:
> + Corrected Javiers e-mail address.
> On Thu, 2015-08-06 at 12:51 +0200, Dirk Behme wrote:
>> On 17.03.2015 15:00, Javier Martinez Canillas wrote:
>>>
>> Having this patch in mainline as commit
>> b23157dc74272ac8ebffd1a566e3e822dbc3e65f [1] breaks our Atmel touch.
>>
>> It seems that above
>>
>> + set_bit(EV_ABS, input_dev->evbit);
>>
>> is missing in the version which went into mainline? Re-adding it
>> makes
>> it work for us, again.
>>
>> Opinions?
>
> In mainline the EV_ABS bit automatically gets set as soon as
> input_set_abs_params get called.
>
> If you're using this patch on an older kernel you should backport
> 2c9a9cfec04f2c6ed7b4e607cd53ca903b2c4642 as well.
>
That's correct. The reason why the original patch had that it's
because it was forward ported from an older kernel and I missed
that detail when doing the rebase.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-08-06 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 14:00 [PATCH 0/2] Input: atmel_mxt_ts - Add support for T100 multi-touch Javier Martinez Canillas
2015-03-17 14:00 ` [PATCH 1/2] Input: atmel_mxt_ts - Implement support for T100 touch object Javier Martinez Canillas
2015-04-06 20:10 ` Dmitry Torokhov
2015-08-06 10:51 ` Dirk Behme
2015-08-06 11:11 ` Sjoerd Simons
2015-08-06 11:19 ` Javier Martinez Canillas [this message]
2015-08-06 13:02 ` Nick Dyer
2015-03-17 14:00 ` [PATCH 2/2] Input: atmel_mxt_ts - Split out touchpad initialisation logic Javier Martinez Canillas
2015-04-06 20:30 ` Dmitry Torokhov
2015-03-27 20:29 ` [PATCH 0/2] Input: atmel_mxt_ts - Add support for T100 multi-touch Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C342B0.1060301@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=bleung@chromium.org \
--cc=cywang@chromium.org \
--cc=dianders@chromium.org \
--cc=dirk.behme@de.bosch.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=nick.dyer@itdev.co.uk \
--cc=olof@lixom.net \
--cc=rydberg@euromail.se \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox