From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751117AbbHGIkI (ORCPT <rfc822;w@1wt.eu>);
	Fri, 7 Aug 2015 04:40:08 -0400
Received: from foss.arm.com ([217.140.101.70]:41772 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750699AbbHGIkG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 7 Aug 2015 04:40:06 -0400
Message-ID: <55C46EE3.9050307@arm.com>
Date: Fri, 07 Aug 2015 09:40:03 +0100
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Ben Zhang <benzh@chromium.org>, Thomas Gleixner <tglx@linutronix.de>
CC: Jason Cooper <jason@lakedaemon.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h
References: <1438925513-17494-1-git-send-email-benzh@chromium.org>
In-Reply-To: <1438925513-17494-1-git-send-email-benzh@chromium.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ben,

On 07/08/15 06:31, Ben Zhang wrote:
> linux/io.h is needed because the driver uses:
> readl_relaxed
> writel_relaxed
> writeq_relaxed
> readq_relaxed
> iounmap
> 
> The header was implicitly included by an unrelated
> commit 332fd7c4fef5
> ("genirq: Generic chip: Change irq_reg_{readl,writel} arguments")
> from the path below:
> include/linux/io.h
> include/linux/irq.h
> include/linux/of_irq.h
> drivers/irqchip/irq-gic-v3.c
> 
> Signed-off-by: Ben Zhang <benzh@chromium.org>
> ---
>  drivers/irqchip/irq-gic-v3.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index e406bc5..3350b8d 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -19,6 +19,7 @@
>  #include <linux/cpu_pm.h>
>  #include <linux/delay.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
>  #include <linux/of_irq.h>
> 

This seems valid, but out of curiosity: Has this triggered any
observable build failure? Or is that something you found by inspection?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...