From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751673AbbHGJJS (ORCPT ); Fri, 7 Aug 2015 05:09:18 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:48428 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbbHGJJO (ORCPT ); Fri, 7 Aug 2015 05:09:14 -0400 X-Helo: d06dlp02.portsmouth.uk.ibm.com X-MailFrom: borntraeger@de.ibm.com X-RcptTo: linux-s390@vger.kernel.org Message-ID: <55C475B3.1080303@de.ibm.com> Date: Fri, 07 Aug 2015 11:09:07 +0200 From: Christian Borntraeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Nicholas Krause , gleb@kernel.org CC: pbonzini@redhat.com, cornelia.huck@de.ibm.com, linux390@de.ibm.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully References: <1438880754-27149-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1438880754-27149-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15080709-0025-0000-0000-00000653CCC1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 06.08.2015 um 19:05 schrieb Nicholas Krause: > This fixes the assumption that kvm_set_irq_routing is always run > successfully by instead making it equal to the variable r which > we use for returning in the function kvm_arch_vm_ioctl instead > of making r equal to zero when calling this particular function > and incorrectly making the caller of kvm_arch_vm_ioctl think > the function has run successfully. > > Signed-off-by: Nicholas Krause > --- > arch/s390/kvm/kvm-s390.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index f32f843..660860f 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -879,8 +879,7 @@ long kvm_arch_vm_ioctl(struct file *filp, > if (kvm->arch.use_irqchip) { > /* Set up dummy routing. */ > memset(&routing, 0, sizeof(routing)); > - kvm_set_irq_routing(kvm, &routing, 0, 0); > - r = 0; > + r = kvm_set_irq_routing(kvm, &routing, 0, 0); > } > break; > } > Thanks, applied with changed prefix (KVM: s390:)