From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932109AbbHGN7i (ORCPT ); Fri, 7 Aug 2015 09:59:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42148 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbbHGN7g (ORCPT ); Fri, 7 Aug 2015 09:59:36 -0400 Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing To: Nicholas Krause , agraf@suse.com References: <1438955228-30116-1-git-send-email-xerofoify@gmail.com> Cc: gleb@kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <55C4B9C0.5030102@redhat.com> Date: Fri, 7 Aug 2015 15:59:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438955228-30116-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2015 15:47, Nicholas Krause wrote: > - kvm_set_irq_routing(opp->kvm, routing, 0, 0); > + ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0); > + if (ret) { > + kfree(routing); > + return ret; > + } > > kfree(routing); > return 0; You could just return ret here. The new "if" is not necessary. Paolo