public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
To: Stewart Smith <stewart@linux.vnet.ibm.com>
Cc: rjw@rjwysocki.net, joel@jms.id.au, viresh.kumar@linaro.org,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org,
	shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Subject: Re: [PATCH v5 2/6] powerpc/powernv: Add definition of OPAL_MSG_OCC message type
Date: Mon, 10 Aug 2015 13:01:22 +0530	[thread overview]
Message-ID: <55C8534A.5040904@linux.vnet.ibm.com> (raw)
In-Reply-To: <m31tfcf0td.fsf@oc8180480414.ibm.com>

Hi Stewart,

On 08/10/2015 05:53 AM, Stewart Smith wrote:
> Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> writes:
>> Add OPAL_MSG_OCC message definition to opal_message_type to receive
>> OCC events like reset, load and throttled. Host performance can be
>> affected when OCC is reset or OCC throttles the max Pstate.
>> We can register to opal_message_notifier to receive OPAL_MSG_OCC type
>> of message and report it to the userspace so as to keep the user
>> informed about the reason for a performance drop in workloads.
>>
>> The reset and load OCC events are notified to kernel when FSP sends
>> OCC_RESET and OCC_LOAD commands.  Both reset and load messages are
>> sent to kernel on successful completion of reset and load operation
>> respectively.
> 
> How is this done on OpenPower systems? Explanation involving just what
> OPAL does is likely better, rather than explaining in context of FSP,
> which Linux has no real knowledge of (OPAL provides all abstraction of
> it).
> 

In OpenPower systems, opal will only send OCC throttled event. OCC reset
and load messages are not sent to kernel.

How about the following git log message?

Add OPAL_MSG_OCC message definition to opal_message_type to receive
OCC events like reset, load and throttled. Host performance can be
affected when OCC is reset or OCC throttles the max Pstate.  We can
register to opal_message_notifier to receive OPAL_MSG_OCC type of
message and report it to the userspace so as to keep the user informed
about the reason for a performance drop in workloads.

Opal will send reset and load events to kernel on successful
completion of reset and load operation of OCC. During this duration
the cpu frequency will be throttled until OCC is started. Opal will
send a throttle message during the OCC reset-cycle to indicate that
OCC is active.

Opal will send throttle message to kernel when OCC is active to
indicate that the Pmax of the chip is reduced. The chip_id and
throttle reason for reducing Pmax is queued along with the message.

Thanks and Regards,
Shilpa


  reply	other threads:[~2015-08-10  7:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  8:04 [PATCH v5 0/6] powernv: cpufreq: Report frequency throttle by OCC Shilpasri G Bhat
2015-07-16  8:04 ` [PATCH v5 1/6] cpufreq: powernv: Handle throttling due to Pmax capping at chip level Shilpasri G Bhat
2015-07-16  8:04 ` [PATCH v5 2/6] powerpc/powernv: Add definition of OPAL_MSG_OCC message type Shilpasri G Bhat
2015-08-10  0:23   ` Stewart Smith
2015-08-10  7:31     ` Shilpasri G Bhat [this message]
2015-07-16  8:04 ` [PATCH v5 3/6] cpufreq: powernv: Register for OCC related opal_message notification Shilpasri G Bhat
2015-08-10  1:41   ` Stewart Smith
2015-08-10  7:51     ` Shilpasri G Bhat
2015-08-10  7:55       ` Viresh Kumar
2015-08-10  8:19       ` Stewart Smith
2015-07-16  8:04 ` [PATCH v5 4/6] cpufreq: powernv: Call throttle_check() on receiving OCC_THROTTLE Shilpasri G Bhat
2015-07-16  8:04 ` [PATCH v5 5/6] cpufreq: powernv: Report Psafe only if PMSR.psafe_mode_active bit is set Shilpasri G Bhat
2015-07-16  8:04 ` [PATCH v5 6/6] cpufreq: powernv: Restore cpu frequency to policy->cur on unthrottling Shilpasri G Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C8534A.5040904@linux.vnet.ibm.com \
    --to=shilpa.bhat@linux.vnet.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=rjw@rjwysocki.net \
    --cc=stewart@linux.vnet.ibm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox