From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932738AbbHJToR (ORCPT ); Mon, 10 Aug 2015 15:44:17 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:36575 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932431AbbHJToP (ORCPT ); Mon, 10 Aug 2015 15:44:15 -0400 Message-ID: <55C8FF0B.50203@gmail.com> Date: Mon, 10 Aug 2015 21:44:11 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 To: Antoine Tenart , thierry.reding@gmail.com CC: zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] Documentation: bindings: document the Berlin PWM driver References: <1438248201-29222-1-git-send-email-antoine.tenart@free-electrons.com> <1438248201-29222-3-git-send-email-antoine.tenart@free-electrons.com> In-Reply-To: <1438248201-29222-3-git-send-email-antoine.tenart@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.07.2015 11:23, Antoine Tenart wrote: > Following the addition of a Berlin PWM driver, this patch adds the > corresponding documentation. > > Signed-off-by: Antoine Tenart > --- > Documentation/devicetree/bindings/pwm/pwm-berlin.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-berlin.txt > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-berlin.txt b/Documentation/devicetree/bindings/pwm/pwm-berlin.txt > new file mode 100644 > index 000000000000..3d7ab7bfbf54 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-berlin.txt > @@ -0,0 +1,15 @@ > +Berlin PWM controller Just a little sentence about "PWM IP found in Marvell Berlin SoCs" ? Besides that, this looks pretty straight-forward to me. Feel free to add my Acked-by: Sebastian Hesselbarth for the Berlin part of it. Sebastian > +Required properties: > +- compatible: should be "marvell,berlin-pwm" > +- reg: physical base address and length of the controller's registers > +- #pwm-cells: should be 3. See pwm.txt in this directory for a description of > + the cells format. > + > +Example: > + > +pwm: pwm@f7f20000 { > + compatible = "marvell,berlin-pwm"; > + reg = <0xf7f20000 0x40>; > + #pwm-cells = <3>; > +} >