From: Guenter Roeck <linux@roeck-us.net>
To: Daniel Kurtz <djkurtz@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Eddie Huang <eddie.huang@mediatek.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Greta Zhang <greta.zhang@mediatek.com>
Subject: Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled
Date: Mon, 10 Aug 2015 21:42:20 -0700 [thread overview]
Message-ID: <55C97D2C.6090505@roeck-us.net> (raw)
In-Reply-To: <CAGS+omD1UYSTfJ4-vZSE_BYuvGcTvpbC7T4ukaV10xuQxkCChg@mail.gmail.com>
On 08/10/2015 09:28 PM, Daniel Kurtz wrote:
> Hi Guenter, Matthias,
>
> On Fri, Jul 24, 2015 at 1:37 AM, Matthias Brugger
> <matthias.bgg@gmail.com> wrote:
>> On Thursday, July 23, 2015 01:49:11 PM Eddie Huang wrote:
>>> From: Greta Zhang <greta.zhang@mediatek.com>
>>>
>>> Without .shutdown(), watchdog might reset the system during power off.
>>> For example, if watchdog's timeout is set to 30s, then it is reset to
>>> zero by mtk_wdt_ping(). During power off, no app will ping watchdog,
>>> but watchdog is still running and may trigger reset.
>>>
>>> Signed-off-by: Greta Zhang <greta.zhang@mediatek.com>
>>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
>>> ---
>>> drivers/watchdog/mtk_wdt.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>
>> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> is the plan to land these two patches via Guenter's watchdog tree [0]?
> [0] git://www.linux-watchdog.org/linux-watchdog.git
>
That is Wim's tree, and Wim is the maintainer ;-).
I have the patches queued in my tree [1], and I plan to send a pull request
to Wim this week or early next week.
Guenter
---
[1] https://git.kernel.org/cgit/linux/kernel/git/groeck/linux-staging.git/log/?h=watchdog-next
next prev parent reply other threads:[~2015-08-11 4:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 5:49 [PATCH v2 0/2] Add Mediatek watchdog suspend resume and shutdown Eddie Huang
2015-07-23 5:49 ` [PATCH v2 1/2] watchdog: add wdt suspend/resume support Eddie Huang
2015-07-23 16:10 ` Guenter Roeck
2015-07-23 17:36 ` Matthias Brugger
2015-07-23 5:49 ` [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled Eddie Huang
2015-07-23 16:12 ` Guenter Roeck
2015-07-23 17:37 ` Matthias Brugger
2015-08-11 4:28 ` Daniel Kurtz
2015-08-11 4:42 ` Guenter Roeck [this message]
2015-08-11 7:38 ` Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C97D2C.6090505@roeck-us.net \
--to=linux@roeck-us.net \
--cc=djkurtz@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=greta.zhang@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox