From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755160AbbHKG4v (ORCPT ); Tue, 11 Aug 2015 02:56:51 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:48291 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754928AbbHKG4u convert rfc822-to-8bit (ORCPT ); Tue, 11 Aug 2015 02:56:50 -0400 X-AuditID: cbfee690-f796f6d000005054-c6-55c99cad075e MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <55C99CAC.7070504@samsung.com> Date: Tue, 11 Aug 2015 15:56:44 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 To: Brian Norris Cc: MyungJoo Ham , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Roger Quadros , "Ivan T . Ivanov" Subject: Re: [PATCH] extcon: fix signedness issues References: <1439231980-105388-1-git-send-email-computersforpeace@gmail.com> In-reply-to: <1439231980-105388-1-git-send-email-computersforpeace@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRsSkWHftnJOhBs0PWSyOXFjLbNG8eD2b xeX5M9ktLu+aw2Zxu3EFm0XPIy0HNo+ds+6ye9y5tofNY//cNewefVtWMXocv7GdyePzJrkA tigum5TUnMyy1CJ9uwSujD9TJjAX3BSt2DS5jbmB8bNgFyMnh4SAicSWp8eYIWwxiQv31rN1 MXJxCAmsYJToOdbJDFO08tFOVojEUkaJRZePsoEkeAUEJX5MvscCYjMLqEtMmreIGcIWkXg5 5ygjhK0tsWzha2aI5geMEpN2PmeFaNaSWHvoNVgzi4CqxOSXp5hAbDag+P4XN8AWiAqESayc fgWsRkRAT+LritnsIIOYBU4ySrw60QmU4OAQFjCSuNkSBVIjJOAj8aXnMjuIzSngK/Fy+h8m kHoJgWvsEv1bXjFCLBOQ+Db5EFivhICsxKYDUF9KShxccYNlAqP4LCS/zULy2ywkv81C8tsC RpZVjKKpBckFxUnpRSZ6xYm5xaV56XrJ+bmbGIFxevrfswk7GO8dsD7EKMDBqMTDK+B5MlSI NbGsuDL3EKMp0EUTmaVEk/OBySCvJN7Q2MzIwtTE1NjI3NJMSZz3tdTPYCGB9MSS1OzU1ILU ovii0pzU4kOMTBycUg2MovwSdy69zTPqudlr7tTmNUdHydm6YX1zipZMwOkZhUyfQkVn3z1u XWly+YmUubvYAudfnCLnn+oe6w19luiQtOnp1Ac7OuZuiAvQ8mZzj874Hcv83fC6zZ39Th8m mT27IZ6myNb7QSMz7a7SpRUrAtTvVXVPY+EwvHpc7adnYVGKndJxL1clluKMREMt5qLiRAAZ fMchzgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t9jAd01c06GGly/bmNx5MJaZovmxevZ LC7Pn8lucXnXHDaL240r2Cx6Hmk5sHnsnHWX3ePOtT1sHvvnrmH36NuyitHj+I3tTB6fN8kF sEU1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAJ2h pFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcxom97HXrBQtKLtwWumBsbd gl2MnBwSAiYSKx/tZIWwxSQu3FvP1sXIxSEksJRRYtHlo2wgCV4BQYkfk++xdDFycDALyEsc uZQNEmYWUJeYNG8RM0T9A0aJSTufs0LUa0msPfSaBcRmEVCVmPzyFBOIzQYU3//iBthMUYEw iZXTr4DViAjoSXxdMZsdZBCzwElGiVcnOsGWCQsYSdxsiQKpERLwkfjSc5kdxOYU8JV4Of0P 0wRGgVlIzpuFcN4sJOctYGRexSiRWpBcUJyUnmuUl1quV5yYW1yal66XnJ+7iREc18+kdzAe 3uV+iFGAg1GJh1fA82SoEGtiWXFl7iFGCQ5mJRHewqlAId6UxMqq1KL8+KLSnNTiQ4ymQP9N ZJYSTc4Hppy8knhDYxMzI0sjc0MLI2NzJXFefZNNoUIC6YklqdmpqQWpRTB9TBycUg2Mmr8W WVd/dFtiZO8fHBUpqFSspJD1tfuT1bR+fYbUcOb5cZ5Xam4KFT6ZeurxR2WuuqOF7lsZ9NY/ qUwNObSNyX+nOtOsiZuCbk2x+Sr+94xRsjy/4pvIudbZnoac+fNkDVwcQ7awZc55uqRi1uMp ESmmx47znV4vIDvjGf8mkR7+Hq4NZ/qUWIozEg21mIuKEwGXpxGkAQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brian, I knew this issue. So patch[1] fixed it already. I sent the extcon pull request[2] including patch[1] for Linux 4.3. [1] http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=a598af7f0279195abffbfb9bf2070457e9c89ff3 [2] https://lkml.org/lkml/2015/8/11/5 Thanks, Chanwoo Choi On 08/11/2015 03:39 AM, Brian Norris wrote: > commit be052cc87745 ("extcon: Fix hang and > extcon_get/set_cable_state().") introduced several signedness issues. > sparse reports them: > > drivers/extcon/extcon.c: In function ‘find_cable_index_by_name’: > drivers/extcon/extcon.c:153:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > drivers/extcon/extcon.c: In function ‘extcon_get_cable_state’: > drivers/extcon/extcon.c:384:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > drivers/extcon/extcon.c: In function ‘extcon_set_cable_state’: > drivers/extcon/extcon.c:432:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > Fixes: be052cc87745 ("extcon: Fix hang and extcon_get/set_cable_state().") > Signed-off-by: Brian Norris > --- > This is *only* compile-tested > > drivers/extcon/extcon.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index 43b57b02d050..a394ca419715 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -126,7 +126,7 @@ static int find_cable_index_by_id(struct extcon_dev *edev, const unsigned int id > > static int find_cable_id_by_name(struct extcon_dev *edev, const char *name) > { > - unsigned int id = -EINVAL; > + int id = -EINVAL; > int i = 0; > > /* Find the id of extcon cable */ > @@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name) > > static int find_cable_index_by_name(struct extcon_dev *edev, const char *name) > { > - unsigned int id; > + int id; > > if (edev->max_supported == 0) > return -EINVAL; > @@ -378,7 +378,7 @@ EXPORT_SYMBOL_GPL(extcon_get_cable_state_); > */ > int extcon_get_cable_state(struct extcon_dev *edev, const char *cable_name) > { > - unsigned int id; > + int id; > > id = find_cable_id_by_name(edev, cable_name); > if (id < 0) > @@ -426,7 +426,7 @@ EXPORT_SYMBOL_GPL(extcon_set_cable_state_); > int extcon_set_cable_state(struct extcon_dev *edev, > const char *cable_name, bool cable_state) > { > - unsigned int id; > + int id; > > id = find_cable_id_by_name(edev, cable_name); > if (id < 0) >