From: Daniel Borkmann <daniel@iogearbox.net>
To: Kaixu Xia <xiakaixu@huawei.com>,
fengguang.wu@intel.com, davem@davemloft.net, ast@plumgrid.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
wangnan0@huawei.com, Michael Holzheu <holzheu@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 net-next] bpf: s390: Fix build error caused by the struct bpf_array member name changed
Date: Tue, 11 Aug 2015 10:24:17 +0200 [thread overview]
Message-ID: <55C9B131.50108@iogearbox.net> (raw)
In-Reply-To: <1439276026-60789-1-git-send-email-xiakaixu@huawei.com>
On 08/11/2015 08:53 AM, Kaixu Xia wrote:
> There is a build error that "'struct bpf_array' has no member
> named 'prog'" on s390. In commit 2a36f0b, the member 'prog' of
> struct bpf_array is replaced by 'ptrs'. So this patch fixes it.
>
> Signed-off-by: Kaixu Xia <xiakaixu@huawei.com>
You were also asked to add a proper Fixes tag :
Fixes: 2a36f0b92eb6 ("bpf: Make the bpf_prog_array_map more generic")
I guess this bug was reported by Fengguang as you have him in Cc ?
If that should be the case, then please also add a "Reported-by:" tag
for his bug report.
Code looks good to me.
next prev parent reply other threads:[~2015-08-11 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 6:53 [PATCH v2 net-next] bpf: s390: Fix build error caused by the struct bpf_array member name changed Kaixu Xia
2015-08-11 8:24 ` Daniel Borkmann [this message]
2015-08-11 8:42 ` xiakaixu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C9B131.50108@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox