From: Juri Lelli <juri.lelli@arm.com>
To: Andrea Parri <parri.andrea@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks
Date: Tue, 11 Aug 2015 10:55:29 +0100 [thread overview]
Message-ID: <55C9C691.8050407@arm.com> (raw)
In-Reply-To: <1438782979-9057-1-git-send-email-parri.andrea@gmail.com>
Hi Andrea,
On 05/08/15 14:56, Andrea Parri wrote:
> The comment is "misleading"; fix it by adapting a comment from
> push_rt_tasks.
>
> Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 0a17af35..7c17001 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1563,7 +1563,7 @@ out:
>
> static void push_dl_tasks(struct rq *rq)
> {
> - /* Terminates as it moves a -deadline task */
> + /* push_dl_task will return true if it moved a -deadline task */
> while (push_dl_task(rq))
> ;
> }
>
Looks good, thanks!
Best,
- Juri
next prev parent reply other threads:[~2015-08-11 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 13:56 [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks Andrea Parri
2015-08-05 13:56 ` [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl Andrea Parri
2015-08-11 10:40 ` Juri Lelli
2015-08-12 12:39 ` [tip:sched/core] sched/deadline: Fix comment in enqueue_task_dl() tip-bot for Andrea Parri
2015-08-11 9:55 ` Juri Lelli [this message]
2015-08-12 12:39 ` [tip:sched/core] sched/deadline: Fix comment in push_dl_tasks() tip-bot for Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C9C691.8050407@arm.com \
--to=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).