Re: [KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches

[Wei Huang <wei@redhat.com>]

On 8/11/15 08:21, Paolo Bonzini wrote:
>
>
> On 07/08/2015 21:53, Wei Huang wrote:
>> These two trivial patches are related to x86 vPMU code. They were
>> actually suggested by Andrew Jones while he was reviewing the last
>> big vPMU patch set.
>>
>> These patches have been compiled and tested on AMD system using
>> a 64-bit guest VM with various perf commands (e.g. bench, test, top,
>> stat). No obvious problems were found.
>>
>> Thanks,
>> -Wei
>>
>> Wei Huang (2):
>>    KVM: x86/vPMU: Move the definition of kvm_pmu_ops to arch-specific
>>      files
>>    KVM: x86/vPMU: Fix unnecessary signed extesion for AMD PERFCTRn
>>
>>   arch/x86/kvm/pmu.h     | 2 --
>>   arch/x86/kvm/pmu_amd.c | 2 --
>>   arch/x86/kvm/svm.c     | 1 +
>>   arch/x86/kvm/vmx.c     | 1 +
>>   4 files changed, 2 insertions(+), 4 deletions(-)
>>
>
> Applied patch 2.  For patch 1 I'm not sure, because I do not really like
> 1) externs in .c files; 2) globals with no declarations in a .h file.
> So I'm leaving it out while I think more about it.
Thanks. The first one is minor anyway. I won't complain about it. :-)

-Wei

>
> Paolo
>