Re: [PATCH 4/4] rtc: s3c: enable/disable clocks for alarm

Joonyoung Shim
2015-08-12T01:09:16Z

On 08/12/2015 09:28 AM, Krzysztof Kozlowski wrote:
> On 11.08.2015 20:28, Joonyoung Shim wrote:
>> The clock enable/disable codes for alarm have removed from
>
> What do you mean in this paragraph? The clock code was removing something?
>
>> 'commit 24e1455493da ("drivers/rtc/rtc-s3c.c: delete duplicate clock
>
> Remove the 'apostrophe.
>
>> control")' and the clocks keep disabling even if alarm is set, so alarm
>> interrupt can't happen.
> ...and the clocks are disabled even...
>
>
>>
>> The s3c_rtc_setaie function can be called several times with that
>> enabled argument has same value,
> ...several times with 'enabled' argument having same value
>
>> so it needs to check whether clocks is
>> enabled or not.
> s/is/are/
>
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>
> Please add Cc-stable and fixes tag. To backport the patch probably
> you'll have to remove the dependency on previous patches.

Thanks for the point, i didn't think it.