From: Paolo Bonzini <pbonzini@redhat.com>
To: Nicholas Krause <xerofoify@gmail.com>, gleb@kernel.org
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm:x86:Fix error handling in the function ioapic_write_indirect
Date: Wed, 12 Aug 2015 14:45:42 +0200 [thread overview]
Message-ID: <55CB3FF6.3000407@redhat.com> (raw)
In-Reply-To: <1439314758-23650-1-git-send-email-xerofoify@gmail.com>
On 11/08/2015 19:39, Nicholas Krause wrote:
> This fixes error handling in the function ioapic_write_indirect to
> properly check if the call to the function ioapoc_service service
> has failed by not returning the value zero to indicate success to
> check if this occurs when calling this particular function and if
> so return immediately to the caller of ioapic_write_indirect due
> to us no longer being able to continue the function
> ioapic_write_indirect after this call fails.
This is not true.
You are back to the older problem that you are not trying to understand
the functions you are modifying.
Paolo
parent reply other threads:[~2015-08-12 12:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1439314758-23650-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB3FF6.3000407@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox