From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbbHLMpt (ORCPT ); Wed, 12 Aug 2015 08:45:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58763 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbbHLMps (ORCPT ); Wed, 12 Aug 2015 08:45:48 -0400 Subject: Re: [PATCH] kvm:x86:Fix error handling in the function ioapic_write_indirect To: Nicholas Krause , gleb@kernel.org References: <1439314758-23650-1-git-send-email-xerofoify@gmail.com> Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <55CB3FF6.3000407@redhat.com> Date: Wed, 12 Aug 2015 14:45:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1439314758-23650-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2015 19:39, Nicholas Krause wrote: > This fixes error handling in the function ioapic_write_indirect to > properly check if the call to the function ioapoc_service service > has failed by not returning the value zero to indicate success to > check if this occurs when calling this particular function and if > so return immediately to the caller of ioapic_write_indirect due > to us no longer being able to continue the function > ioapic_write_indirect after this call fails. This is not true. You are back to the older problem that you are not trying to understand the functions you are modifying. Paolo