From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751923AbbHMENu (ORCPT ); Thu, 13 Aug 2015 00:13:50 -0400 Received: from mail-ob0-f176.google.com ([209.85.214.176]:33811 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbbHMENs (ORCPT ); Thu, 13 Aug 2015 00:13:48 -0400 Message-ID: <55CC1979.2080608@gmail.com> Date: Wed, 12 Aug 2015 21:13:45 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Nicholas Krause CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] genet:Fix error handling in the function bcmgenet_fini_gma References: <1439432875-2992-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1439432875-2992-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 08/12/15 19:27, Nicholas Krause a écrit : > This fixes error handing in the function bcmgenet_fini_gma to > properly check if its internal call to the function > bcm_genet_teardown has failed by returning a error code and if > so return immediately to this function's caller with a return > statement as this function call can no longer continue without > issues arising from the call to the function bcm_genet_teardown. NACK, this is not a good idea, there are specific reasons why the DMA teardown can fail, e.g: when no bandwidth has been allocated at the memory controller level, and we still want to keep tearing down and freeing up resources while we reconfigure the controller one way or the other, this can happen while debugging a system, and this is specific to how GENET is integrated on Broadcom BCM7xxx SoCs. Also, if you ever need to submit more patches, please look at the git log history and use consistent prefixes, for this driver this would be "net: bcmgenet: blah blah" > > Signed-off-by: Nicholas Krause > --- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > index 64c1e9d..50e6183 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > @@ -2180,7 +2180,8 @@ static void bcmgenet_fini_dma(struct bcmgenet_priv *priv) > bcmgenet_fini_tx_napi(priv); > > /* disable DMA */ > - bcmgenet_dma_teardown(priv); > + if (bcmgenet_dma_teardown(priv)) > + return; > > for (i = 0; i < priv->num_tx_bds; i++) { > if (priv->tx_cbs[i].skb != NULL) { > -- Florian