From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752099AbbHMHYM (ORCPT ); Thu, 13 Aug 2015 03:24:12 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:44867 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbbHMHYK (ORCPT ); Thu, 13 Aug 2015 03:24:10 -0400 X-AuditID: cbfee691-f79ca6d00000456a-33-55cc46187d84 Message-id: <55CC4618.2070007@samsung.com> Date: Thu, 13 Aug 2015 16:24:08 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Roger Quadros Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, u.kleine-koenig@pengutronix.de, jim.epost@gmail.com Subject: Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change References: <1439425744-20009-1-git-send-email-cw00.choi@samsung.com> <55CC4211.7030804@ti.com> In-reply-to: <55CC4211.7030804@ti.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWyRsSkUFfC7Uyowe0Hehb9r5YzW1zeNYfN oueRlsXWvVfZLW5PnMzowOrReOMGm8fOWXfZPfr/Gngcv7GdyePzJrkA1igum5TUnMyy1CJ9 uwSujNUbOAouclc8/LGPuYHxFmcXIyeHhICJxItTLxkhbDGJC/fWs3UxcnEICaxglHjRe4K1 i5EDrOjO7VCI+CxGia0rulkgnAeMEvcPTGMH6eYV0JLYNuMb2CQWAVWJC2u+g8XZgOL7X9xg A7FFBcIkVk6/wgJRLyjxY/I9MFtEQFHi3sr1YDXMArkSt9ZtAZsjLJAgsXjpEbC4kECixO+V J8FsTgE1ib5nrYwgxzEL6Encv6gF0SovsXnNW2aQ2yQE9rFL7AWrAblHQOLb5EMsEM/ISmw6 wAzxsKTEwRU3WCYwis1CctEshKmzkExdwMi8ilE0tSC5oDgpvchUrzgxt7g0L10vOT93EyMw sk7/ezZxB+P9A9aHGAU4GJV4eDmeng4VYk0sK67MPcRoCnTERGYp0eR8YPzmlcQbGpsZWZia mBobmVuaKYnz6kj/DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAaJjWIuZb7uWldtnupe6S Kb+5ks5PSeJsMtpt8bjw+/pNU3vcZ0+P2bgiWVDcqHjuV/u0wtDY6I7ckAmmLBanPI6Wyls/ f78yyYXP97nIo7IJVz2KZH+9cUrbtjRHSvo4q+vCJpWIC+nWeXXZWqfemF2ydZwk8IPnbbBm 9KppGdtzdAPEN29RYinOSDTUYi4qTgQAJXLmf6cCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jQV0JtzOhBgv7tCz6Xy1ntri8aw6b Rc8jLYute6+yW9yeOJnRgdWj8cYNNo+ds+6ye/T/NfA4fmM7k8fnTXIBrFENjDYZqYkpqUUK qXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QLuVFMoSc0qBQgGJxcVK +naYJoSGuOlawDRG6PqGBMH1GBmggYQ1jBmrN3AUXOSuePhjH3MD4y3OLkYODgkBE4k7t0O7 GDmBTDGJC/fWs3UxcnEICcxilNi6opsFwnnAKHH/wDR2kCpeAS2JbTO+MYLYLAKqEhfWfAeL swHF97+4wQZiiwqESaycfoUFol5Q4sfke2C2iICixL2V68FqmAVyJW6t2wI2R1ggQWLx0iNg cSGBRInfK0+C2ZwCahJ9z1oZQQ5lFtCTuH9RC6JVXmLzmrfMExiBrkTYMAuhahaSqgWMzKsY JVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgqP3mfQOxsO73A8xCnAwKvHwcjw9HSrEmlhW XJl7iFGCg1lJhPeo3JlQId6UxMqq1KL8+KLSnNTiQ4ymwCCYyCwlmpwPTCx5JfGGxiZmRpZG 5oYWRsbmSuK8+iabQoUE0hNLUrNTUwtSi2D6mDg4pRoYZRsOR2t82u3y7u3Dmg1L9hc+z72g nZFyrTwhIqQmade0u9YvTuvN8HrY+837lUjZ4R0bH5QfDT07+UVOkqbsZalKrVJGvbMaHptk ld4zvHLTa+g6ZWsheKPTO21TQGR/glfaZB8RvRkFexa+/qdZM4nBJulQ8plLGp8bXTXFz6qt sBFeWPdIiaU4I9FQi7moOBEAeG1HxPQCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/13/2015 04:06 PM, Roger Quadros wrote: > Hi Chanwoo, > > On 13/08/15 03:29, Chanwoo Choi wrote: >> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >> changes the prototype of devm_gpiod_get_optional() API which should include >> the falgs mandatory. > > s/falgs/flags > >> >> Reported-by: Stephen Rothwell >> Signed-off-by: Chanwoo Choi >> --- >> drivers/extcon/extcon-palmas.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c >> index 662e91778cb0..308928d44ead 100644 >> --- a/drivers/extcon/extcon-palmas.c >> +++ b/drivers/extcon/extcon-palmas.c >> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev) >> palmas_usb->wakeup = pdata->wakeup; >> } >> >> - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id"); >> + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", >> + GPIOD_IN); >> if (IS_ERR(palmas_usb->id_gpiod)) { >> dev_err(&pdev->dev, "failed to get id gpio\n"); >> return PTR_ERR(palmas_usb->id_gpiod); >> > > Can you please include the following headers in this patch? > > #include > #include I think that extcon-palmas need only "#include " because of of_gpio.h file already include the gpio.h. Thanks, Chanwoo Choi