From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbbHMH0Y (ORCPT ); Thu, 13 Aug 2015 03:26:24 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:35442 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903AbbHMH0W (ORCPT ); Thu, 13 Aug 2015 03:26:22 -0400 Message-ID: <55CC468A.4010301@ti.com> Date: Thu, 13 Aug 2015 10:26:02 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Chanwoo Choi CC: , , , Subject: Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change References: <1439425744-20009-1-git-send-email-cw00.choi@samsung.com> <55CC4211.7030804@ti.com> <55CC4618.2070007@samsung.com> In-Reply-To: <55CC4618.2070007@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/08/15 10:24, Chanwoo Choi wrote: > > On 08/13/2015 04:06 PM, Roger Quadros wrote: >> Hi Chanwoo, >> >> On 13/08/15 03:29, Chanwoo Choi wrote: >>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >>> changes the prototype of devm_gpiod_get_optional() API which should include >>> the falgs mandatory. >> >> s/falgs/flags >> >>> >>> Reported-by: Stephen Rothwell >>> Signed-off-by: Chanwoo Choi >>> --- >>> drivers/extcon/extcon-palmas.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c >>> index 662e91778cb0..308928d44ead 100644 >>> --- a/drivers/extcon/extcon-palmas.c >>> +++ b/drivers/extcon/extcon-palmas.c >>> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev) >>> palmas_usb->wakeup = pdata->wakeup; >>> } >>> >>> - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id"); >>> + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", >>> + GPIOD_IN); >>> if (IS_ERR(palmas_usb->id_gpiod)) { >>> dev_err(&pdev->dev, "failed to get id gpio\n"); >>> return PTR_ERR(palmas_usb->id_gpiod); >>> >> >> Can you please include the following headers in this patch? >> >> #include >> #include > > I think that extcon-palmas need only "#include " > because of of_gpio.h file already include the gpio.h. OK with me. cheers, -roger