From: Chanwoo Choi <cw00.choi@samsung.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, rogerq@ti.com
Subject: Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
Date: Thu, 13 Aug 2015 17:15:11 +0900 [thread overview]
Message-ID: <55CC520F.6030800@samsung.com> (raw)
In-Reply-To: <20150813071450.GX9999@pengutronix.de>
On 08/13/2015 04:14 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote:
>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>> changes the prototype of devm_gpiod_get_optional() API which should include
>> the falgs mandatory.
> I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to
> pass the flags argument." After all it is possible (and recommended)
> already now to use it. Your wording sounds as if b17d1bf16cc7 changed
> the API in an incompatible way.
OK, I'll modify the patch description by using your recommened sentence.
Thanks,
Chanwoo Choi
prev parent reply other threads:[~2015-08-13 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 0:29 [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change Chanwoo Choi
2015-08-13 7:06 ` Roger Quadros
2015-08-13 7:24 ` Chanwoo Choi
2015-08-13 7:26 ` Roger Quadros
2015-08-13 7:14 ` Uwe Kleine-König
2015-08-13 8:15 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC520F.6030800@samsung.com \
--to=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=sfr@canb.auug.org.au \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox