From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbbHMIPp (ORCPT ); Thu, 13 Aug 2015 04:15:45 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:57730 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbbHMIPm (ORCPT ); Thu, 13 Aug 2015 04:15:42 -0400 MIME-version: 1.0 Content-type: text/plain; charset=windows-1252 X-AuditID: cbfee691-f79ca6d00000456a-57-55cc520f4662 Content-transfer-encoding: 8BIT Message-id: <55CC520F.6030800@samsung.com> Date: Thu, 13 Aug 2015 17:15:11 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 To: =?windows-1252?Q?Uwe_Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, rogerq@ti.com Subject: Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change References: <1439425744-20009-1-git-send-email-cw00.choi@samsung.com> <20150813071450.GX9999@pengutronix.de> In-reply-to: <20150813071450.GX9999@pengutronix.de> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42JZI2JSossfdCbU4PNKQYvLu+awWfQ80rLY uvcqu8XtiZMZHVg8Gm/cYPPo/2vgcfzGdiaPz5vkAliiuGxSUnMyy1KL9O0SuDI+bzrEVjCb teL52RPMDYzzWboYOTkkBEwkZk3Zwg5hi0lcuLeerYuRi0NIYAWjxMmJ95lgik6++MYMkVjK KNG+9B1YN6+AoMSPyfeAbA4OZgF5iSOXsiFMPYn7F7Ugyh8wSuza0MoOUa4l8eX5bzYQm0VA VeL7w4lg89mA4vtf3ACLiwqESaycfgVsvIiAl8T9qxvBbGYBV4kDP7pZQWxhgQSJxUuPgNUL CeRJLPl3DSzOKWAs8ezEP0aIm9exS6x+qAexS0Di2+RDYGdKCMhKbDrADFEiKXFwxQ2WCYxi s5A8MwvhmVkIzyxgZF7FKJpakFxQnJReZKpXnJhbXJqXrpecn7uJERhDp/89m7iD8f4B60OM AhyMSjy8HE9PhwqxJpYVV+YeYjQFumEis5Rocj4wUvNK4g2NzYwsTE1MjY3MLc2UxHl1pH8G CwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamDkUVu8RjPXtkonn08oKvpOap5w1jVN2aMLeh9m N4kde1YWePabX3hsc3789SdPzI/zvJxuw15+Y/5PjxU7tp3q6s+TN1A8UDPb8xCbpE7nLNWY TwtLbxk3+uWHZF79Y7NTP7Fs/f9Tt7qXLbwSk/ryn82lQ8cVhZ5qTPqpFm0ZFt5X9zvH/LYS S3FGoqEWc1FxIgBADnPDnAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jAV3+oDOhBs/OcVlc3jWHzaLnkZbF 1r1X2S1uT5zM6MDi0XjjBptH/18Dj+M3tjN5fN4kF8AS1cBok5GamJJapJCal5yfkpmXbqvk HRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0UUmhLDGnFCgUkFhcrKRvh2lCaIibrgVM Y4Sub0gQXI+RARpIWMOY8XnTIbaC2awVz8+eYG5gnM/SxcjJISFgInHyxTdmCFtM4sK99Wxd jFwcQgJLGSXal74DK+IVEJT4MfkekM3BwSwgL3HkUjaEqSdx/6IWRPkDRoldG1rZIcq1JL48 /80GYrMIqEp8fziRCcRmA4rvf3EDLC4qECaxcvoVsPEiAl4S969uBLOZBVwlDvzoZgWxhQUS JBYvPQJWLySQJ7Hk3zWwOKeAscSzE/8YJzAKzEJy3SyE62YhXLeAkXkVo0RqQXJBcVJ6rlFe arlecWJucWleul5yfu4mRnCkPpPewXh4l/shRgEORiUeXo6np0OFWBPLiitzDzFKcDArifAe lTsTKsSbklhZlVqUH19UmpNafIjRFOi9icxSosn5wCSSVxJvaGxiZmRpZG5oYWRsriTOq2+y KVRIID2xJDU7NbUgtQimj4mDU6qBscXRiGvhj9DsEKe3cx2+qR/Zd+F3eku1vvaV2BlzXq96 v0rtetn741Wr72S9CF22+Oy87jb1PQ+fapifyXHpjbgkzPPv37Eq0+fMKX+ZzjHeqJo/oSw0 /M6i4sIzP/LZpp/om/qjI72XS6Fn+/skL628A1b7pcT3yKo0PKqfc/1Nf8HVbkmxB0osxRmJ hlrMRcWJAH8+jKXqAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/13/2015 04:14 PM, Uwe Kleine-König wrote: > Hello, > > On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote: >> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >> changes the prototype of devm_gpiod_get_optional() API which should include >> the falgs mandatory. > I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to > pass the flags argument." After all it is possible (and recommended) > already now to use it. Your wording sounds as if b17d1bf16cc7 changed > the API in an incompatible way. OK, I'll modify the patch description by using your recommened sentence. Thanks, Chanwoo Choi