* [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
@ 2015-08-13 0:29 Chanwoo Choi
2015-08-13 7:06 ` Roger Quadros
2015-08-13 7:14 ` Uwe Kleine-König
0 siblings, 2 replies; 6+ messages in thread
From: Chanwoo Choi @ 2015-08-13 0:29 UTC (permalink / raw)
To: linux-kernel; +Cc: cw00.choi, sfr, u.kleine-koenig, rogerq
Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
changes the prototype of devm_gpiod_get_optional() API which should include
the falgs mandatory.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/extcon/extcon-palmas.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 662e91778cb0..308928d44ead 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
palmas_usb->wakeup = pdata->wakeup;
}
- palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
+ palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
+ GPIOD_IN);
if (IS_ERR(palmas_usb->id_gpiod)) {
dev_err(&pdev->dev, "failed to get id gpio\n");
return PTR_ERR(palmas_usb->id_gpiod);
--
1.8.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
2015-08-13 0:29 [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change Chanwoo Choi
@ 2015-08-13 7:06 ` Roger Quadros
2015-08-13 7:24 ` Chanwoo Choi
2015-08-13 7:14 ` Uwe Kleine-König
1 sibling, 1 reply; 6+ messages in thread
From: Roger Quadros @ 2015-08-13 7:06 UTC (permalink / raw)
To: Chanwoo Choi, linux-kernel; +Cc: sfr, u.kleine-koenig, jim.epost
Hi Chanwoo,
On 13/08/15 03:29, Chanwoo Choi wrote:
> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> changes the prototype of devm_gpiod_get_optional() API which should include
> the falgs mandatory.
s/falgs/flags
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/extcon/extcon-palmas.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 662e91778cb0..308928d44ead 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
> palmas_usb->wakeup = pdata->wakeup;
> }
>
> - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> + GPIOD_IN);
> if (IS_ERR(palmas_usb->id_gpiod)) {
> dev_err(&pdev->dev, "failed to get id gpio\n");
> return PTR_ERR(palmas_usb->id_gpiod);
>
Can you please include the following headers in this patch?
#include <linux/gpio.h>
#include <linux/gpio/consumer.h>
This should fix the randconfig build errors reported by Jim Davis at
http://article.gmane.org/gmane.linux.kernel/2018960
cheers,
-roger
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
2015-08-13 7:06 ` Roger Quadros
@ 2015-08-13 7:24 ` Chanwoo Choi
2015-08-13 7:26 ` Roger Quadros
0 siblings, 1 reply; 6+ messages in thread
From: Chanwoo Choi @ 2015-08-13 7:24 UTC (permalink / raw)
To: Roger Quadros; +Cc: linux-kernel, sfr, u.kleine-koenig, jim.epost
On 08/13/2015 04:06 PM, Roger Quadros wrote:
> Hi Chanwoo,
>
> On 13/08/15 03:29, Chanwoo Choi wrote:
>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>> changes the prototype of devm_gpiod_get_optional() API which should include
>> the falgs mandatory.
>
> s/falgs/flags
>
>>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> drivers/extcon/extcon-palmas.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
>> index 662e91778cb0..308928d44ead 100644
>> --- a/drivers/extcon/extcon-palmas.c
>> +++ b/drivers/extcon/extcon-palmas.c
>> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>> palmas_usb->wakeup = pdata->wakeup;
>> }
>>
>> - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
>> + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
>> + GPIOD_IN);
>> if (IS_ERR(palmas_usb->id_gpiod)) {
>> dev_err(&pdev->dev, "failed to get id gpio\n");
>> return PTR_ERR(palmas_usb->id_gpiod);
>>
>
> Can you please include the following headers in this patch?
>
> #include <linux/gpio.h>
> #include <linux/gpio/consumer.h>
I think that extcon-palmas need only "#include <linux/gpio/consumer.h>"
because of of_gpio.h file already include the gpio.h.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
2015-08-13 7:24 ` Chanwoo Choi
@ 2015-08-13 7:26 ` Roger Quadros
0 siblings, 0 replies; 6+ messages in thread
From: Roger Quadros @ 2015-08-13 7:26 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: linux-kernel, sfr, u.kleine-koenig, jim.epost
On 13/08/15 10:24, Chanwoo Choi wrote:
>
> On 08/13/2015 04:06 PM, Roger Quadros wrote:
>> Hi Chanwoo,
>>
>> On 13/08/15 03:29, Chanwoo Choi wrote:
>>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>>> changes the prototype of devm_gpiod_get_optional() API which should include
>>> the falgs mandatory.
>>
>> s/falgs/flags
>>
>>>
>>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>> drivers/extcon/extcon-palmas.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
>>> index 662e91778cb0..308928d44ead 100644
>>> --- a/drivers/extcon/extcon-palmas.c
>>> +++ b/drivers/extcon/extcon-palmas.c
>>> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>>> palmas_usb->wakeup = pdata->wakeup;
>>> }
>>>
>>> - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
>>> + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
>>> + GPIOD_IN);
>>> if (IS_ERR(palmas_usb->id_gpiod)) {
>>> dev_err(&pdev->dev, "failed to get id gpio\n");
>>> return PTR_ERR(palmas_usb->id_gpiod);
>>>
>>
>> Can you please include the following headers in this patch?
>>
>> #include <linux/gpio.h>
>> #include <linux/gpio/consumer.h>
>
> I think that extcon-palmas need only "#include <linux/gpio/consumer.h>"
> because of of_gpio.h file already include the gpio.h.
OK with me.
cheers,
-roger
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
2015-08-13 0:29 [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change Chanwoo Choi
2015-08-13 7:06 ` Roger Quadros
@ 2015-08-13 7:14 ` Uwe Kleine-König
2015-08-13 8:15 ` Chanwoo Choi
1 sibling, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2015-08-13 7:14 UTC (permalink / raw)
To: Chanwoo Choi; +Cc: linux-kernel, sfr, rogerq
Hello,
On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote:
> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> changes the prototype of devm_gpiod_get_optional() API which should include
> the falgs mandatory.
I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to
pass the flags argument." After all it is possible (and recommended)
already now to use it. Your wording sounds as if b17d1bf16cc7 changed
the API in an incompatible way.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change
2015-08-13 7:14 ` Uwe Kleine-König
@ 2015-08-13 8:15 ` Chanwoo Choi
0 siblings, 0 replies; 6+ messages in thread
From: Chanwoo Choi @ 2015-08-13 8:15 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, sfr, rogerq
On 08/13/2015 04:14 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Aug 13, 2015 at 09:29:04AM +0900, Chanwoo Choi wrote:
>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>> changes the prototype of devm_gpiod_get_optional() API which should include
>> the falgs mandatory.
> I'd write: "With commit b17d1bf16cc7 ("...") it becomes necessary to
> pass the flags argument." After all it is possible (and recommended)
> already now to use it. Your wording sounds as if b17d1bf16cc7 changed
> the API in an incompatible way.
OK, I'll modify the patch description by using your recommened sentence.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-08-13 8:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-13 0:29 [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change Chanwoo Choi
2015-08-13 7:06 ` Roger Quadros
2015-08-13 7:24 ` Chanwoo Choi
2015-08-13 7:26 ` Roger Quadros
2015-08-13 7:14 ` Uwe Kleine-König
2015-08-13 8:15 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox