From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752210AbbHMJwX (ORCPT ); Thu, 13 Aug 2015 05:52:23 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:40085 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbbHMJwW (ORCPT ); Thu, 13 Aug 2015 05:52:22 -0400 Message-ID: <55CC68A0.40101@ti.com> Date: Thu, 13 Aug 2015 12:51:28 +0300 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Sudeep Holla , Marc Zyngier CC: "tglx@linutronix.de" , "tony@atomide.com" , "linux@arm.linux.org.uk" , "jason@lakedaemon.net" , "nsekhar@ti.com" , "linux-kernel@vger.kernel.org" , "balbi@ti.com" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE References: <1439401562-28874-1-git-send-email-grygorii.strashko@ti.com> <1439401562-28874-3-git-send-email-grygorii.strashko@ti.com> <55CC5B2F.7060503@arm.com> In-Reply-To: <55CC5B2F.7060503@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/13/2015 11:54 AM, Sudeep Holla wrote: > > > On 12/08/15 18:45, Grygorii Strashko wrote: >> The irqchip_set_wake_parent should not fail if IRQ chip >> specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup >> configuration can't be propagated properly through IRQ >> domains hierarchy. >> >> In case of TI OMAP DRA7 the issue reproduced with following >> configuration: >> ARM GIC<-OMAP wakeupgen<-TI CBAR<-GPIO<-GPIO pcf857x<-gpio_key >> >> gpio_key is wakeup source >> >> Failure is reproduced during suspend/resume to RAM: >> suspend: >> - gpio_keys_suspend >> enable_irq_wake >> + pcf857x_irq_set_wake >> + omap_gpio_wake_enable >> + TI CBAR irq_chip_set_wake_parent >> + OMAP wakeupgen has no .irq_set_wake() >> and -ENOSYS will be returned >> >> resume: >> - gpio_keys_resume >> + disable_irq_wake >> + irq_set_irq_wake >> + WARN(1, "Unbalanced IRQ %d wake disable\n", irq); >> >> Fixes: 08b55e2a9208 ('genirq: Add irqchip_set_wake_parent') >> Signed-off-by: Grygorii Strashko >> --- >> kernel/irq/chip.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c >> index 6de638b..bdb1b9d 100644 >> --- a/kernel/irq/chip.c >> +++ b/kernel/irq/chip.c >> @@ -1024,6 +1024,10 @@ int irq_chip_set_vcpu_affinity_parent(struct >> irq_data *data, void *vcpu_info) >> int irq_chip_set_wake_parent(struct irq_data *data, unsigned int on) >> { >> data = data->parent_data; >> + >> + if (irq_data_get_irq_chip(data)->flags & IRQCHIP_SKIP_SET_WAKE) >> + return 0; >> + > > [Nit] I think the irq core can access data->chip directly. Either way, > it's better to be consistent, the statement following doesn't use helper > function. thanks. I'll change it to: if (data->chip->flags & IRQCHIP_SKIP_SET_WAKE) return 0; > > Otherwise looks good to me. Does it means that I can add your Reviewed-by: with above change? > >> if (data->chip->irq_set_wake) >> return data->chip->irq_set_wake(data, on); >> >> -- regards, -grygorii