Re: [PATCH] selftests/zram: Adding zram tests

Shuah Khan
2015-08-13T19:36:23Z

On 08/13/2015 01:08 PM, Naresh Kamboju wrote:
> Hi Tyler,
>
> On 23 July 2015 at 05:30, Tyler Baker <tyler.baker@linaro.org> wrote:
>> Hi Naresh,
>>
>> On 7 July 2015 at 05:03, <naresh.kamboju@linaro.org> wrote:
>>> From: Naresh Kamboju <naresh.kamboju@linaro.org>
>>>
>>> zram_lib.sh: create library with initialization/cleanup functions
>>> zram01.sh: creates general purpose ram disks with different filesystems
>>> zram02.sh: creates block device for swap
>>> README: ZRAM introduction and Kconfig required.
>>> Makefile: To run zram tests
>>
>> (./zram01.sh && echo "selftests: zram01.sh [PASS]") || echo
>> "selftests: zram01.sh [FAIL]"
>> (./zram02.sh && echo "selftests: zram02.sh [PASS]") || echo
>> "selftests: zram02.sh [FAIL]"
>> (./zram_lib.sh && echo "selftests: zram_lib.sh [PASS]") || echo
>> "selftests: zram_lib.sh [FAIL]"
>>
>> Above is the output from the run_kselftests.sh. Do we want to run
>> zram_lib.sh as a test case as it just a library?
>
> zram_lib.sh is not a test as it just a library.
> run_kselftest.sh should not pick this file as test case. Any idea howto ?
>

TEST_PROGS := zram01.sh zram02.sh zram_lib.sh

The above tells run_kselftest.sh to run these.
You will have to add zram_lib.h to TEST_FILES instead.

Please take a look at other tests that do this. e.g: net/Makefile

thanks,
-- Shuah

--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978