From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750852AbbHOENf (ORCPT ); Sat, 15 Aug 2015 00:13:35 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:58084 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbbHOENd (ORCPT ); Sat, 15 Aug 2015 00:13:33 -0400 Message-ID: <55CEBC6B.9070001@wwwdotorg.org> Date: Fri, 14 Aug 2015 22:13:31 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Eric Anholt CC: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Stephen Boyd , Mike Turquette , devicetree@vger.kernel.org Subject: Re: [PATCH v5 3/3] ARM: bcm2835: Add DT for the firmware clocks driver. References: <1439507142-2965-1-git-send-email-eric@anholt.net> <1439507142-2965-4-git-send-email-eric@anholt.net> In-Reply-To: <1439507142-2965-4-git-send-email-eric@anholt.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/13/2015 05:05 PM, Eric Anholt wrote: > Signed-off-by: Eric Anholt > Acked-by: Lee Jones A patch description might be nice, although admittedly the subject seems clear enough. > diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi > + firmware_clocks: firmware-clocks { > + compatible = "raspberrypi,bcm2835-firmware-clocks"; > + #clock-cells = <1>; > + raspberrypi,firmware = <&firmware>; > + }; No need to resend for this, but just a background note: DT node names usually contain a device type not a device identity, so "clocks" not "firmware-clocks" would be typical. This patch, Acked-by: Stephen Warren