Re: [PATCH v5 3/3] ARM: bcm2835: Add DT for the firmware clocks driver.

Lee Jones
2015-08-27T10:49:04Z

On Fri, 14 Aug 2015, Stephen Warren wrote:

> On 08/13/2015 05:05 PM, Eric Anholt wrote:
> > Signed-off-by: Eric Anholt <eric@anholt.net>
> > Acked-by: Lee Jones <lee@kernel.org>
>
> A patch description might be nice, although admittedly the subject seems
> clear enough.

Agreed that the subject is clear enough on this occasion.

> > diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
>
> > + firmware_clocks: firmware-clocks {
> > + compatible = "raspberrypi,bcm2835-firmware-clocks";
> > + #clock-cells = <1>;
> > + raspberrypi,firmware = <&firmware>;
> > + };
>
> No need to resend for this, but just a background note: DT node names
> usually contain a device type not a device identity, so "clocks" not
> "firmware-clocks" would be typical.

Please fix this up when you re-send the set.

> This patch,
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>