From: Lars Melin <larsm17@gmail.com>
To: Chase Metzger <chasemetzger15@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Petr Mladek <pmladek@suse.cz>,
Peter Chen <peter.chen@freescale.com>,
Felipe Balbi <balbi@ti.com>, Matthew Garrett <mjg59@coreos.com>,
Robert Schlabbach <Robert.Schlabbach@gmx.net>,
Zhuang Jin Can <jin.can.zhuang@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: core: hub: Removed some warnings generated by checkpatch.pl
Date: Sat, 15 Aug 2015 12:10:10 +0700 [thread overview]
Message-ID: <55CEC9B2.6040804@gmail.com> (raw)
In-Reply-To: <1439613714-14835-1-git-send-email-chasemetzger15@gmail.com>
On 2015-08-15 11:41, Chase Metzger wrote:
> Removed some checkpatch.pl warnings saying there was an unwanted space between
> function names and their arguments.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
> drivers/usb/core/hub.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 38cb6d3..b9cab51 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -4218,7 +4218,7 @@ static int hub_enable_device(struct usb_device *udev)
> * but it is still necessary to lock the port.
> */
> static int
> -hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1,
> +hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1,
> int retry_counter)
> {
> struct usb_device *hdev = hub->hdev;
> @@ -4522,7 +4522,7 @@ fail:
> }
>
> static void
> -check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
> +check_highspeed(struct usb_hub *hub, struct usb_device *udev, int port1)
> {
> struct usb_qualifier_descriptor *qual;
> int status;
> @@ -4530,11 +4530,11 @@ check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
> if (udev->quirks & USB_QUIRK_DEVICE_QUALIFIER)
> return;
>
> - qual = kmalloc (sizeof *qual, GFP_KERNEL);
> + qual = kmalloc(sizeof *qual, GFP_KERNEL);
> if (qual == NULL)
> return;
>
> - status = usb_get_descriptor (udev, USB_DT_DEVICE_QUALIFIER, 0,
> + status = usb_get_descriptor udev, USB_DT_DEVICE_QUALIFIER, 0,
> qual, sizeof *qual);
If you had test compiled you would have got an unbalanced parenthesis
error here. So you didn't test your patch..
next prev parent reply other threads:[~2015-08-15 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-15 4:41 [PATCH] usb: core: hub: Removed some warnings generated by checkpatch.pl Chase Metzger
2015-08-15 5:10 ` Lars Melin [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-19 3:36 Chase Metzger
2015-08-12 4:34 Chase Metzger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CEC9B2.6040804@gmail.com \
--to=larsm17@gmail.com \
--cc=Robert.Schlabbach@gmx.net \
--cc=balbi@ti.com \
--cc=chasemetzger15@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jin.can.zhuang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mjg59@coreos.com \
--cc=peter.chen@freescale.com \
--cc=pmladek@suse.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox