From: Jens Axboe <axboe@fb.com>
To: Ming Lei <ming.lei@canonical.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/2] blk-mq: two fixes
Date: Sat, 15 Aug 2015 09:44:50 -0600 [thread overview]
Message-ID: <55CF5E72.3010205@fb.com> (raw)
In-Reply-To: <CACVXFVNJcgTLMzVDQGqUz2FPsOa=UJ9ax+Osv0KGwnNhiQF6mw@mail.gmail.com>
On 08/14/2015 07:10 PM, Ming Lei wrote:
> On Sun, Aug 9, 2015 at 3:41 PM, Ming Lei <ming.lei@canonical.com> wrote:
>> Hi Jens,
>>
>> The 1st patch fixes one buffer overflow issue when reading
>> sysfs file of hctx's pending.
>>
>> The 2nd patch fixes one race between timeout and request freeing,
>> which also simplifies implementation of blk_mq_tag_to_rq() a lot.
>
> Ping...
Sorry, 1/2 is a no brainer, needed a bit of time to look at 2/2. I think
it looks fine, and I like how it simplifies (and gets rid of) the flush
special case tag lookup. Applied.
--
Jens Axboe
next prev parent reply other threads:[~2015-08-15 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-09 7:41 [PATCH 0/2] blk-mq: two fixes Ming Lei
2015-08-09 7:41 ` [PATCH 1/2] blk-mq: fix buffer overflow when reading sysfs file of 'pending' Ming Lei
2015-08-09 7:41 ` [PATCH 2/2] blk-mq: fix race between timeout and freeing request Ming Lei
2015-08-15 1:10 ` [PATCH 0/2] blk-mq: two fixes Ming Lei
2015-08-15 15:44 ` Jens Axboe [this message]
2015-08-16 9:25 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CF5E72.3010205@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox