From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbbHOPo7 (ORCPT ); Sat, 15 Aug 2015 11:44:59 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:5667 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbbHOPo5 (ORCPT ); Sat, 15 Aug 2015 11:44:57 -0400 Message-ID: <55CF5E72.3010205@fb.com> Date: Sat, 15 Aug 2015 09:44:50 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Ming Lei , Linux Kernel Mailing List CC: Christoph Hellwig Subject: Re: [PATCH 0/2] blk-mq: two fixes References: <1439106111-26293-1-git-send-email-ming.lei@canonical.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-15_03:2015-08-13,2015-08-15,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/14/2015 07:10 PM, Ming Lei wrote: > On Sun, Aug 9, 2015 at 3:41 PM, Ming Lei wrote: >> Hi Jens, >> >> The 1st patch fixes one buffer overflow issue when reading >> sysfs file of hctx's pending. >> >> The 2nd patch fixes one race between timeout and request freeing, >> which also simplifies implementation of blk_mq_tag_to_rq() a lot. > > Ping... Sorry, 1/2 is a no brainer, needed a bit of time to look at 2/2. I think it looks fine, and I like how it simplifies (and gets rid of) the flush special case tag lookup. Applied. -- Jens Axboe