From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754794AbbHQMbk (ORCPT ); Mon, 17 Aug 2015 08:31:40 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:34689 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbbHQMbh (ORCPT ); Mon, 17 Aug 2015 08:31:37 -0400 Message-ID: <55D1D426.8020504@linaro.org> Date: Mon, 17 Aug 2015 13:31:34 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stefan Wahren CC: wxt@rock-chips.com, linux-api@vger.kernel.org, Rob Herring , p.zabel@pengutronix.de, Andrew Lunn , sboyd@codeaurora.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, khilman@kernel.org, maitysanchayan@gmail.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mporter@konsulko.com, pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org, Mark Brown , Greg Kroah-Hartman Subject: Re: [PATCH RFC 3/3] nvmem: add permission flags in nvmem_config References: <1439290931-18232-1-git-send-email-srinivas.kandagatla@linaro.org> <1439291024-18375-1-git-send-email-srinivas.kandagatla@linaro.org> <1634428787.18822.1439623316281.JavaMail.open-xchange@oxbsltgw04.schlund.de> In-Reply-To: <1634428787.18822.1439623316281.JavaMail.open-xchange@oxbsltgw04.schlund.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/15 08:21, Stefan Wahren wrote: > Hi Srinivas, > >> Srinivas Kandagatla hat am 11. August 2015 um >> 13:03 geschrieben: >> >> >> This patch adds perm variable to nvmem_config structure which will allow >> providers to specify the permissions required for the sysfs binary file. >> This permission is applied on top of root-only access permissions set by >> the core. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/nvmem/core.c | 1 + >> include/linux/nvmem-provider.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c >> index 414ed23..7481387 100644 >> --- a/drivers/nvmem/core.c >> +++ b/drivers/nvmem/core.c >> @@ -312,6 +312,7 @@ struct nvmem_device *nvmem_register(const struct >> nvmem_config *config) >> config->read_only; >> nvmem->bin = bin_attr_template; >> nvmem->bin.attr.mode = nvmem->read_only ? : (S_IRUSR | S_IWUSR); >> + nvmem->bin.attr.mode |= config->perm; >> nvmem->bin.size = nvmem->size; >> device_initialize(&nvmem->dev); >> >> diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h >> index 0b68caf..de9a61f 100644 >> --- a/include/linux/nvmem-provider.h >> +++ b/include/linux/nvmem-provider.h >> @@ -23,6 +23,7 @@ struct nvmem_config { >> const struct nvmem_cell_info *cells; >> int ncells; >> bool read_only; >> + u16 perm; /* visibility in sysfs */ > > how about "umode_t mode" or "umode_t sysfs_mode"? > Yep, "umode_t mode" sounds much better. I will use it that. --srini > Beside that the whole series looks good to me. > > Thanks Stefan >