From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751386AbbHQVTv (ORCPT ); Mon, 17 Aug 2015 17:19:51 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:39030 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbbHQVTr convert rfc822-to-8bit (ORCPT ); Mon, 17 Aug 2015 17:19:47 -0400 Subject: Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used To: Guenter Roeck , Steve Glendinning References: <1439844336-21596-1-git-send-email-linux@roeck-us.net> Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jeremy Linton Message-ID: <55D24FEE.8040505@arm.com> Date: Mon, 17 Aug 2015 16:19:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1439844336-21596-1-git-send-email-linux@roeck-us.net> X-OriginalArrivalTime: 17 Aug 2015 21:19:45.0058 (UTC) FILETIME=[705E8820:01D0D932] X-MC-Unique: AXTfd-IoTIe0fS9Vr4jykg-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2015 03:45 PM, Guenter Roeck wrote: > Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes > the call to smsc911x_probe_config() unconditional, and no longer fails if > there is no device node. device_get_phy_mode() is called unconditionally, > and if there is no phy node configured returns an error code. This error > code is assigned to phy_interface, and interpreted elsewhere in the code > as valid phy mode. This in turn causes qemu to crash when running a > variant of realview_pb_defconfig. Thanks for catching that! I have a couple other minor cleanups per the reviewers. Jeremy