From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbbHQWPG (ORCPT ); Mon, 17 Aug 2015 18:15:06 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:36401 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbbHQWPE (ORCPT ); Mon, 17 Aug 2015 18:15:04 -0400 Message-ID: <55D25CE0.6040203@roeck-us.net> Date: Mon, 17 Aug 2015 15:14:56 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Jeremy Linton , Steve Glendinning CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used References: <1439844336-21596-1-git-send-email-linux@roeck-us.net> <55D24FEE.8040505@arm.com> In-Reply-To: <55D24FEE.8040505@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2015 02:19 PM, Jeremy Linton wrote: > On 08/17/2015 03:45 PM, Guenter Roeck wrote: >> Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes >> the call to smsc911x_probe_config() unconditional, and no longer fails if >> there is no device node. device_get_phy_mode() is called unconditionally, >> and if there is no phy node configured returns an error code. This error >> code is assigned to phy_interface, and interpreted elsewhere in the code >> as valid phy mode. This in turn causes qemu to crash when running a >> variant of realview_pb_defconfig. > > Thanks for catching that! I have a couple other minor cleanups per the reviewers. > One nitpick I noticed after sending my patch: dev can never be NULL in smsc911x_probe_config(), so it does not really make sense to check if it is NULL. Guenter