From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbbHQWfI (ORCPT ); Mon, 17 Aug 2015 18:35:08 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:34417 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbbHQWfG convert rfc822-to-8bit (ORCPT ); Mon, 17 Aug 2015 18:35:06 -0400 Subject: Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used To: Guenter Roeck , Steve Glendinning References: <1439844336-21596-1-git-send-email-linux@roeck-us.net> <55D24FEE.8040505@arm.com> <55D25CE0.6040203@roeck-us.net> Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jeremy Linton Message-ID: <55D26194.5060702@arm.com> Date: Mon, 17 Aug 2015 17:35:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55D25CE0.6040203@roeck-us.net> X-OriginalArrivalTime: 17 Aug 2015 22:35:03.0498 (UTC) FILETIME=[F591C2A0:01D0D93C] X-MC-Unique: x1-jq_dFSKi3DRiT9SM_4A-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2015 05:14 PM, Guenter Roeck wrote: > One nitpick I noticed after sending my patch: dev can never be NULL in > smsc911x_probe_config(), so it does not really make sense to check if it is NULL. No, it doesn't... it should really be something like if (dev_fwnode(dev)) But dev_fwnode is static inline in property.c, and i'm pretty sure that still isn't 100% correct.The best plan might just be to remove the check, and abort on failure to find the phy property per your patch.