From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbbHRBjI (ORCPT ); Mon, 17 Aug 2015 21:39:08 -0400 Received: from mga14.intel.com ([192.55.52.115]:4823 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbbHRBjH (ORCPT ); Mon, 17 Aug 2015 21:39:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,698,1432623600"; d="scan'208";a="750514389" Message-ID: <55D28D87.2080800@intel.com> Date: Tue, 18 Aug 2015 09:42:31 +0800 From: Yu Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Darren Hart CC: "joe@perches.com" , "linux-kernel@vger.kernel.org" , "Zhang, Rui" , "jslaby@suse.com" , "platform-driver-x86@vger.kernel.org" , "akpm@linux-foundation.org" , "Wysocki, Rafael J" , "Westerberg, Mika" , "gregkh@linuxfoundation.org" , "mchehab@osg.samsung.com" , "arnd@arndb.de" Subject: Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons References: <1438934272-17959-1-git-send-email-yu.c.chen@intel.com> <1438936078.2322.29.camel@perches.com> <1438937513.2723.10.camel@localhost> <20150811024524.GA3095@vmdeb7> In-Reply-To: <20150811024524.GA3095@vmdeb7> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/2015 10:45 AM, Darren Hart wrote: > On Fri, Aug 07, 2015 at 08:48:18AM +0000, Chen, Yu C wrote: >> On Fri, 2015-08-07 at 01:27 -0700, Joe Perches wrote: >>> On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: \ >>> >>> I think the older switch/case was easier to understand. >>> >> OK, then let's keep the switch/case. >> thanks. > > Agreed. > Hi, Darren and Joe, I'll send a V4 of this patch to add a method to exclude the load of Surface 3(no Pro), since Surface 3 also has a device name of MSHW0028, but it is not used for buttons. Thanks Best Regards, Yu >