From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbbHROFa (ORCPT ); Tue, 18 Aug 2015 10:05:30 -0400 Received: from lists.s-osg.org ([54.187.51.154]:58316 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbbHROF3 (ORCPT ); Tue, 18 Aug 2015 10:05:29 -0400 Subject: Re: [PATCH] platform/chrome: Make CROS_EC_PROTO a user selectable option To: Geert Uytterhoeven References: <1439882106-23406-1-git-send-email-javier@osg.samsung.com> <1525696.gQFOjPpKHL@amdc1976> <55D32CE2.3050605@osg.samsung.com> <4744942.ssWfRsvQQJ@amdc1976> <55D336D8.5070902@osg.samsung.com> Cc: Bartlomiej Zolnierkiewicz , Olof Johansson , Doug Anderson , Gwendal Grignou , Sjoerd Simons , "linux-kernel@vger.kernel.org" From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Message-ID: <55D33BA0.1090502@osg.samsung.com> Date: Tue, 18 Aug 2015 16:05:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Geert, On 08/18/2015 03:54 PM, Geert Uytterhoeven wrote: > Hi Javier, > > On Tue, Aug 18, 2015 at 3:44 PM, Javier Martinez Canillas > wrote: >>>> Yes, the original Kconfig warning message was: >>>> >>>> warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM) >>>> >>>> Paul fixed on [0] by making MFD_CROS_EC depends on X86 || ARM but that >>>> is not really true since the driver could be used in other platforms so >>>> I tried to instead fix it by removing unneeded dependencies in [1] but >>>> one of the patches was nacked by Geert [2] who mentioned the issue about >>>> mixing select and "depends on". >>> >>> I think that Geert's comments are valid. Dependencies should limit >>> the config option to the archs for which the driver is really needed >>> (the rest can be handled with COMPILE_TEST dependency). >>> >> >> Yes, which is true for the drivers under CHROME_PLATFORMS (i.e: CROS_EC_LPC >> has X86 || COMPILE_TEST) but my point was that CHROME_PLATFORMS is not a >> driver but a submenu that has (for now) drivers for ARM and X86. But that >> doesn't mean that a Chromebook for another arch could be produced and then >> you will need to add a X86 || ARM || FOO || BAR || COMPILE_TEST for >> CHROME_PLATFORMS which seems to me kind of silly. > > However, that's usually the way it is done: such a dependency is added to > prevent the question from showing up on platforms where it doesn't make > sense. > > If the drivers become needed on other platforms, the dependency can be > relaxed. > Ok, I'll reintroduce the arch dependency for CHROME_PLATFORMS then and add a || COMPILE_TEST. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America