From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754290AbbHRW2r (ORCPT ); Tue, 18 Aug 2015 18:28:47 -0400 Received: from lists.s-osg.org ([54.187.51.154]:58356 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753606AbbHRW2p (ORCPT ); Tue, 18 Aug 2015 18:28:45 -0400 Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver To: Olof Johansson References: <1439881827-22613-1-git-send-email-javier@osg.samsung.com> <20150818214608.GA21855@localhost> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: arm@kernel.org, Arnd Bergmann , Geert Uytterhoeven , Doug Anderson , Gwendal Grignou , Sjoerd Simons , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz Message-ID: <55D3B195.6030608@osg.samsung.com> Date: Wed, 19 Aug 2015 00:28:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150818214608.GA21855@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Olof, On 08/18/2015 11:46 PM, Olof Johansson wrote: > On Tue, Aug 18, 2015 at 09:10:27AM +0200, Javier Martinez Canillas wrote: >> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config >> symbol because the driver uses some communication helper functions in >> drivers/platform/chrome/cros_ec_proto.c but other drivers depends on >> CROS_EC_PROTO instead. Mixing select and depends can lead to circular >> Kconfig dependencies so the MFD_CROS_EC select should be changed to a >> depends on CROS_EC_PROTO instead. >> >> But doing so will break git bisect-ability since MFD_CROS_EC will not >> be enabled anymore unless the default configs first explicitly enable >> the CROS_EC_PROTO dependency. >> >> Signed-off-by: Javier Martinez Canillas > > Applied to cros/ec-config in arm-soc, which will stay stable in case others > need to bring in as a prereq. > Thanks but Bartolomiej's feedback [0] on my patch that made CROS_EC_PROTO a user selectable option was to leave it as a non-visible option and instead change the other Kconfig symbols to select CROS_EC_PROTO consistently. So tomorrow I'll post a new patch series along those lines that will make this patch obsolete since no defconfig changes will be needed. IOW, please drop this patch and sorry for the inconvenience. > > -Olof > [0]: https://lkml.org/lkml/2015/8/18/231 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America