public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, "Pádraig Brady" <P@draigBrady.com>
Subject: Re: [PATCH v4] tags: much faster, parallel "make tags"
Date: Wed, 19 Aug 2015 15:25:40 +0200	[thread overview]
Message-ID: <55D483D4.5020905@suse.cz> (raw)
In-Reply-To: <20150511202515.GB7650@p183.telecom.by>

On 2015-05-11 22:25, Alexey Dobriyan wrote:
> ctags is single-threaded program. Split list of files to be tagged into
> almost equal parts, process them on every CPU and merge the results.

Sorry, I missed the v4 of the patch.


> +	# Remove headers.
> +	for i in .make-tags.t*; do
> +		sed -i -e '/^!/d' $i
> +	done
> +
> +	# Write final header.
> +	$1 -f $2 /dev/null
> +
> +	# Append sorted results.
> +	sort .make-tags.t* >>$2
> +	rm -f .make-tags.t*

This still breaks Exuberant ctags in emacs mode:
$ ln -s /usr/bin/ctags ~/bin/etags
$ make TAGS
  GEN     TAGS
etags: "TAGS" doesn't look like a tag file; I refuse to overwrite it.
etags: "TAGS" doesn't look like a tag file; I refuse to overwrite it.

The TAGS file is corrupted because of the sorting.

Michal

      reply	other threads:[~2015-08-19 13:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 13:26 [PATCH v3] tags: much faster, parallel "make tags" Alexey Dobriyan
2015-05-09  5:07 ` Pádraig Brady
2015-05-10 13:26   ` Alexey Dobriyan
2015-05-10 13:53     ` Alexey Dobriyan
2015-05-10 20:58     ` Pádraig Brady
2015-05-11 20:20       ` Alexey Dobriyan
2015-05-11 20:25         ` [PATCH v4] " Alexey Dobriyan
2015-08-19 13:25           ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D483D4.5020905@suse.cz \
    --to=mmarek@suse.cz \
    --cc=P@draigBrady.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox