public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
	linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 4/4] [media] media: remove media entity .parent field
Date: Thu, 20 Aug 2015 14:43:31 +0200	[thread overview]
Message-ID: <55D5CB73.6090202@xs4all.nl> (raw)
In-Reply-To: <1439998526-12832-5-git-send-email-javier@osg.samsung.com>

On 08/19/15 17:35, Javier Martinez Canillas wrote:
> Now that the struct media_entity .parent field is unused, it can be
> safely removed. Since all the previous users were converted to use
> the .mdev field from the embedded struct media_gobj instead.
> 
> Suggested-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

> 
> ---
> 
>  include/media/media-entity.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index 3b653e9321f2..d7e007f624a5 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -103,7 +103,6 @@ struct media_entity_operations {
>  struct media_entity {
>  	struct media_gobj graph_obj;
>  	struct list_head list;
> -	struct media_device *parent;	/* Media device this entity belongs to*/
>  	const char *name;		/* Entity name */
>  	u32 type;			/* Entity type (MEDIA_ENT_T_*) */
>  	u32 revision;			/* Entity revision, driver specific */
> 

  reply	other threads:[~2015-08-20 12:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 15:35 [PATCH 0/4] [media] Media entity cleanups and build fixes Javier Martinez Canillas
2015-08-19 15:35 ` [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id() Javier Martinez Canillas
2015-08-20 18:37   ` Laurent Pinchart
2015-08-21  0:14     ` Javier Martinez Canillas
2015-08-21  0:15       ` Laurent Pinchart
2015-08-21  0:31         ` Javier Martinez Canillas
2015-08-21  7:49         ` Hans Verkuil
2015-08-19 15:35 ` [PATCH 2/4] [media] omap3isp: " Javier Martinez Canillas
2015-08-19 15:35 ` [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent Javier Martinez Canillas
2015-08-20 12:43   ` Hans Verkuil
2015-08-19 15:35 ` [PATCH 4/4] [media] media: remove media entity .parent field Javier Martinez Canillas
2015-08-20 12:43   ` Hans Verkuil [this message]
2015-08-19 16:58 ` [PATCH 0/4] [media] Media entity cleanups and build fixes Mauro Carvalho Chehab
2015-08-20 12:41 ` Hans Verkuil
2015-08-20 12:50   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D5CB73.6090202@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=javier@osg.samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox