From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075AbbHTVpR (ORCPT ); Thu, 20 Aug 2015 17:45:17 -0400 Received: from lists.s-osg.org ([54.187.51.154]:58886 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbbHTVpO (ORCPT ); Thu, 20 Aug 2015 17:45:14 -0400 Subject: Re: [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT To: Brian Norris , Mark Brown References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-19-git-send-email-javier@osg.samsung.com> <20150820183634.GN12027@sirena.org.uk> <20150820210822.GH74600@google.com> Cc: linux-kernel@vger.kernel.org, Javier Martinez Canillas , linux-spi@vger.kernel.org From: Javier Martinez Canillas Message-ID: <55D64A65.7030905@osg.samsung.com> Date: Thu, 20 Aug 2015 23:45:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150820210822.GH74600@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/20/2015 11:08 PM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 11:36:34AM -0700, Mark Brown wrote: >> On Thu, Aug 20, 2015 at 09:07:31AM +0200, Javier Martinez Canillas wrote: >>> From: Javier Martinez Canillas >>> >>> An SPI driver that supports both OF and legacy platforms, will have >>> both an OF and SPI ID table. This means that when built as a module, >>> the aliases will be filled from both tables, e.g: >> >> This is tagged as something that can't be applied but you've not >> explained why it can't be applied or what comments might be useful :( > As Brian pointed out it was in the cover letter so I thought it would just be duplicated information. But you are right, I should had added a brief note as well just to make the patch self contained. > I believe that's mostly addressed in the cover letter [1]. > > Patch #18 changes the logic of spi_uevent() to report an OF modalias > if the device was registered using OF. But this patch is included in > the series only as an RFC for illustration purposes since changing > that without first applying all the other patches in this series, will > break module autoloading for the drivers of devices registered using > OF but that lacks an of_match_table. I'll repost patch #18 once all > the patches in this series have landed. > > IOW, it's labeled as such mostly for safety, since it has quite a few > distributed dependencies. > That's correct. If is merged before the other patches, module autoloading will break for the drivers that are relying on the current behavior. I just added for illustration purposes to show what was the plan. > Brian > > [1] https://lkml.org/lkml/2015/8/20/109 > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America