From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()
Date: Fri, 21 Aug 2015 02:14:05 +0200 [thread overview]
Message-ID: <55D66D4D.2030307@osg.samsung.com> (raw)
In-Reply-To: <3021244.b1huftRsSL@avalon>
Hello Laurent,
On 08/20/2015 08:37 PM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thank you for the patch.
>
> On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote:
>> The struct media_entity does not have an .id field anymore since
>> now the entity ID is stored in the embedded struct media_gobj.
>>
>> This caused the omap4iss driver fail to build. Fix by using the
>> media_entity_id() macro to obtain the entity ID.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> This looks fine to me. The patch needs to be moved between Mauro's 1/8 and 2/8
> patches to avoid breaking bisection with patch 3/8. I'd squash this patch and
> 2/4 into a single "media: Use media_entity_id() in drivers" patch.
>
Yes, Hans and Mauro already mentioned it and I completely agree that
should be squashed with Mauro's patch to maintain git bisect-ability.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-08-21 0:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 15:35 [PATCH 0/4] [media] Media entity cleanups and build fixes Javier Martinez Canillas
2015-08-19 15:35 ` [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id() Javier Martinez Canillas
2015-08-20 18:37 ` Laurent Pinchart
2015-08-21 0:14 ` Javier Martinez Canillas [this message]
2015-08-21 0:15 ` Laurent Pinchart
2015-08-21 0:31 ` Javier Martinez Canillas
2015-08-21 7:49 ` Hans Verkuil
2015-08-19 15:35 ` [PATCH 2/4] [media] omap3isp: " Javier Martinez Canillas
2015-08-19 15:35 ` [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent Javier Martinez Canillas
2015-08-20 12:43 ` Hans Verkuil
2015-08-19 15:35 ` [PATCH 4/4] [media] media: remove media entity .parent field Javier Martinez Canillas
2015-08-20 12:43 ` Hans Verkuil
2015-08-19 16:58 ` [PATCH 0/4] [media] Media entity cleanups and build fixes Mauro Carvalho Chehab
2015-08-20 12:41 ` Hans Verkuil
2015-08-20 12:50 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D66D4D.2030307@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox