From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752347AbbHUMdm (ORCPT ); Fri, 21 Aug 2015 08:33:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40905 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbbHUMdl (ORCPT ); Fri, 21 Aug 2015 08:33:41 -0400 Subject: Re: [PATCH RFT] phy: sun4i-usb: Use devm_gpiod_get_optional for optional GPIOs To: Axel Lin , Kishon Vijay Abraham I References: <1440146978.29130.1.camel@ingics.com> Cc: Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: <55D71AA1.9050607@redhat.com> Date: Fri, 21 Aug 2015 14:33:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1440146978.29130.1.camel@ingics.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 21-08-15 10:49, Axel Lin wrote: > Both data->id_det_gpio and data->vbus_det_gpio are optional, so use > devm_gpiod_get_optional for them. > > Signed-off-by: Axel Lin Thanks for the patch, looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/phy/phy-sun4i-usb.c | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c > index 731b395..b12964b 100644 > --- a/drivers/phy/phy-sun4i-usb.c > +++ b/drivers/phy/phy-sun4i-usb.c > @@ -551,19 +551,15 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev) > if (IS_ERR(data->base)) > return PTR_ERR(data->base); > > - data->id_det_gpio = devm_gpiod_get(dev, "usb0_id_det", GPIOD_IN); > - if (IS_ERR(data->id_det_gpio)) { > - if (PTR_ERR(data->id_det_gpio) == -EPROBE_DEFER) > - return -EPROBE_DEFER; > - data->id_det_gpio = NULL; > - } > - > - data->vbus_det_gpio = devm_gpiod_get(dev, "usb0_vbus_det", GPIOD_IN); > - if (IS_ERR(data->vbus_det_gpio)) { > - if (PTR_ERR(data->vbus_det_gpio) == -EPROBE_DEFER) > - return -EPROBE_DEFER; > - data->vbus_det_gpio = NULL; > - } > + data->id_det_gpio = devm_gpiod_get_optional(dev, "usb0_id_det", > + GPIOD_IN); > + if (IS_ERR(data->id_det_gpio)) > + return PTR_ERR(data->id_det_gpio); > + > + data->vbus_det_gpio = devm_gpiod_get_optional(dev, "usb0_vbus_det", > + GPIOD_IN); > + if (IS_ERR(data->vbus_det_gpio)) > + return PTR_ERR(data->vbus_det_gpio); > > if (of_find_property(np, "usb0_vbus_power-supply", NULL)) { > data->vbus_power_supply = devm_power_supply_get_by_phandle(dev, >