From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbbHUTGF (ORCPT ); Fri, 21 Aug 2015 15:06:05 -0400 Received: from mga09.intel.com ([134.134.136.24]:11921 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbbHUTGD (ORCPT ); Fri, 21 Aug 2015 15:06:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,723,1432623600"; d="scan'208,223";a="773292704" Message-ID: <55D77696.60102@intel.com> Date: Fri, 21 Aug 2015 22:05:58 +0300 From: Adrian Hunter User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Jiri Olsa , Linux Kernel Mailing List Subject: Re: perf: make tarball broken by some file added by pt/bts References: <20150821163347.GG30343@kernel.org> In-Reply-To: <20150821163347.GG30343@kernel.org> Content-Type: multipart/mixed; boundary="------------030606090702020508090305" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------030606090702020508090305 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 21/08/2015 7:33 p.m., Arnaldo Carvalho de Melo wrote: > CC util/scripting-engines/trace-event-python.o > CC util/intel-pt-decoder/intel-pt-insn-decoder.o > util/intel-pt-decoder/intel-pt-insn-decoder.c:23:22: fatal error: > asm/insn.h: No such file or directory > #include > ^ > compilation terminated. Here is what I found was needed --------------030606090702020508090305 Content-Type: text/plain; charset=windows-1252; name="0001-perf-tools-Fix-tarball-build-broken-by-pt-bts.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-perf-tools-Fix-tarball-build-broken-by-pt-bts.patch" >>From 8d36bfbc31c4a845b0a22b2dd4fcca86be7f0058 Mon Sep 17 00:00:00 2001 From: Adrian Hunter Date: Fri, 21 Aug 2015 21:57:42 +0300 Subject: [PATCH] perf tools: Fix tarball build broken by pt/bts Fix some include paths and add missing inat_types.h. Signed-off-by: Adrian Hunter --- tools/perf/tests/perf-targz-src-pkg | 2 +- tools/perf/util/intel-pt-decoder/inat.c | 2 +- tools/perf/util/intel-pt-decoder/inat.h | 2 +- tools/perf/util/intel-pt-decoder/inat_types.h | 29 ++++++++++++++++++++++ tools/perf/util/intel-pt-decoder/insn.c | 4 +-- tools/perf/util/intel-pt-decoder/insn.h | 2 +- .../util/intel-pt-decoder/intel-pt-insn-decoder.c | 2 +- 7 files changed, 36 insertions(+), 7 deletions(-) create mode 100644 tools/perf/util/intel-pt-decoder/inat_types.h diff --git a/tools/perf/tests/perf-targz-src-pkg b/tools/perf/tests/perf-targz-src-pkg index 238aa39..261a912 100755 --- a/tools/perf/tests/perf-targz-src-pkg +++ b/tools/perf/tests/perf-targz-src-pkg @@ -17,5 +17,5 @@ rm -f ${TARBALL} cd - > /dev/null make -C $TMP_DEST/perf*/tools/perf > /dev/null 2>&1 RC=$? -rm -rf ${TMP_DEST} +#rm -rf ${TMP_DEST} exit $RC diff --git a/tools/perf/util/intel-pt-decoder/inat.c b/tools/perf/util/intel-pt-decoder/inat.c index feeaa50..906d94a 100644 --- a/tools/perf/util/intel-pt-decoder/inat.c +++ b/tools/perf/util/intel-pt-decoder/inat.c @@ -18,7 +18,7 @@ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. * */ -#include +#include "insn.h" /* Attribute tables are generated from opcode map */ #include "inat-tables.c" diff --git a/tools/perf/util/intel-pt-decoder/inat.h b/tools/perf/util/intel-pt-decoder/inat.h index 74a2e31..611645e 100644 --- a/tools/perf/util/intel-pt-decoder/inat.h +++ b/tools/perf/util/intel-pt-decoder/inat.h @@ -20,7 +20,7 @@ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. * */ -#include +#include "inat_types.h" /* * Internal bits. Don't use bitmasks directly, because these bits are diff --git a/tools/perf/util/intel-pt-decoder/inat_types.h b/tools/perf/util/intel-pt-decoder/inat_types.h new file mode 100644 index 0000000..cb3c20c --- /dev/null +++ b/tools/perf/util/intel-pt-decoder/inat_types.h @@ -0,0 +1,29 @@ +#ifndef _ASM_X86_INAT_TYPES_H +#define _ASM_X86_INAT_TYPES_H +/* + * x86 instruction attributes + * + * Written by Masami Hiramatsu + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. + * + */ + +/* Instruction attributes */ +typedef unsigned int insn_attr_t; +typedef unsigned char insn_byte_t; +typedef signed int insn_value_t; + +#endif diff --git a/tools/perf/util/intel-pt-decoder/insn.c b/tools/perf/util/intel-pt-decoder/insn.c index 8f72b33..47314a6 100644 --- a/tools/perf/util/intel-pt-decoder/insn.c +++ b/tools/perf/util/intel-pt-decoder/insn.c @@ -23,8 +23,8 @@ #else #include #endif -#include -#include +#include "inat.h" +#include "insn.h" /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ diff --git a/tools/perf/util/intel-pt-decoder/insn.h b/tools/perf/util/intel-pt-decoder/insn.h index e7814b7..dd12da0 100644 --- a/tools/perf/util/intel-pt-decoder/insn.h +++ b/tools/perf/util/intel-pt-decoder/insn.h @@ -21,7 +21,7 @@ */ /* insn_attr_t is defined in inat.h */ -#include +#include "inat.h" struct insn_field { union { diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-insn-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-insn-decoder.c index 46980fc..9e4eb8f 100644 --- a/tools/perf/util/intel-pt-decoder/intel-pt-insn-decoder.c +++ b/tools/perf/util/intel-pt-decoder/intel-pt-insn-decoder.c @@ -20,7 +20,7 @@ #include "event.h" -#include +#include "insn.h" #include "inat.c" #include "insn.c" -- 1.9.1 --------------030606090702020508090305--