From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbbHVACR (ORCPT ); Fri, 21 Aug 2015 20:02:17 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:34692 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbbHVACQ (ORCPT ); Fri, 21 Aug 2015 20:02:16 -0400 Message-ID: <55D7BB71.6020601@gmail.com> Date: Fri, 21 Aug 2015 16:59:45 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: David Daney , netdev@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org CC: David Daney , Lennert Buytenhek , Grant Likely Subject: Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent. References: <1440198963-20080-1-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1440198963-20080-1-git-send-email-ddaney.cavm@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/08/15 16:16, David Daney wrote: > From: David Daney > > commit 18ee49ddb0d2 ("phylib: rename mii_bus::dev to mii_bus::parent") > changed the parent of PHY devices from the bus to the bus parent. > > Then, commit 4dea547fef1b ("phylib: rework to prepare for OF > registration of PHYs") moved the code into phy_device.c > > At this point, it is somewhat unclear why the change was seen as > necessary. But, when we look at the device model tree in > /sys/devices, it is clearly incorrect. The PHYs should be children of > their MDIO bus. > > Change the PHY's parent device to be the MDIO bus device. > > Cc: Lennert Buytenhek > Cc: Grant Likely > Signed-off-by: David Daney Acked-by: Florian Fainelli -- Florian