From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbbHVR7X (ORCPT ); Sat, 22 Aug 2015 13:59:23 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:38159 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753097AbbHVR7V (ORCPT ); Sat, 22 Aug 2015 13:59:21 -0400 Subject: Re: [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-3-git-send-email-javier@osg.samsung.com> Cc: devel@driverdev.osuosl.org, linux-iio@vger.kernel.org, Peter Meerwald , Krzysztof Kozlowski , Lars-Peter Clausen , Greg Kroah-Hartman , Hartmut Knaack From: Jonathan Cameron X-Enigmail-Draft-Status: N1110 Message-ID: <55D8B875.3060200@kernel.org> Date: Sat, 22 Aug 2015 18:59:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1440054451-1223-3-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/08/15 08:07, Javier Martinez Canillas wrote: > The SPI core always reports the MODALIAS uevent as "spi:" > regardless of the mechanism that was used to register the device > (i.e: OF or board code) and the table that is used later to match > the driver with the device (i.e: SPI id table or OF match table). > > So drivers needs to export the SPI id table and this be built into > the module or udev won't have the necessary information to autoload > the needed driver module when the device is added. > > Signed-off-by: Javier Martinez Canillas Applied to the togreg branch of iio.git. This is too late for the upcoming merge window so it will be queued up for the next one. Thanks, Jonathan > --- > > drivers/staging/iio/magnetometer/hmc5843_spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/iio/magnetometer/hmc5843_spi.c b/drivers/staging/iio/magnetometer/hmc5843_spi.c > index 8e658f736e1f..4dfb372d2fec 100644 > --- a/drivers/staging/iio/magnetometer/hmc5843_spi.c > +++ b/drivers/staging/iio/magnetometer/hmc5843_spi.c > @@ -81,6 +81,7 @@ static const struct spi_device_id hmc5843_id[] = { > { "hmc5983", HMC5983_ID }, > { } > }; > +MODULE_DEVICE_TABLE(spi, hmc5843_id); > > static struct spi_driver hmc5843_driver = { > .driver = { >